From de1c687f7e8280ce472ee07fd3673933120b954d Mon Sep 17 00:00:00 2001 From: Christian Stein Date: Wed, 12 Dec 2018 23:02:33 +0100 Subject: [PATCH] [SUREFIRE-1614] Add failing IT --- .../its/JUnitPlatformStreamCorruptionIT.java | 55 +++++++++++++++++++ .../surefire-1614-stream-corruption/pom.xml | 35 ++++++++++++ .../java/com/example/demo/CustomRunner.java | 19 +++++++ .../demo/SurefireStreamCorruptionTest.java | 13 +++++ 4 files changed, 122 insertions(+) create mode 100644 surefire-its/src/test/java/org/apache/maven/surefire/its/JUnitPlatformStreamCorruptionIT.java create mode 100644 surefire-its/src/test/resources/surefire-1614-stream-corruption/pom.xml create mode 100644 surefire-its/src/test/resources/surefire-1614-stream-corruption/src/test/java/com/example/demo/CustomRunner.java create mode 100644 surefire-its/src/test/resources/surefire-1614-stream-corruption/src/test/java/com/example/demo/SurefireStreamCorruptionTest.java diff --git a/surefire-its/src/test/java/org/apache/maven/surefire/its/JUnitPlatformStreamCorruptionIT.java b/surefire-its/src/test/java/org/apache/maven/surefire/its/JUnitPlatformStreamCorruptionIT.java new file mode 100644 index 0000000000..5820114498 --- /dev/null +++ b/surefire-its/src/test/java/org/apache/maven/surefire/its/JUnitPlatformStreamCorruptionIT.java @@ -0,0 +1,55 @@ +package org.apache.maven.surefire.its; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import org.apache.maven.it.VerificationException; +import org.apache.maven.surefire.its.fixture.OutputValidator; +import org.apache.maven.surefire.its.fixture.SurefireJUnit4IntegrationTestCase; +import org.junit.Before; +import org.junit.Test; + +import java.util.List; + +import static org.apache.maven.surefire.its.fixture.HelperAssertions.assumeJavaVersion; +import static org.fest.assertions.Assertions.assertThat; +import static org.hamcrest.CoreMatchers.startsWith; + +public class JUnitPlatformStreamCorruptionIT + extends SurefireJUnit4IntegrationTestCase +{ + @Before + public void setUp() + { + assumeJavaVersion( 1.8d ); + } + + @Test + public void warningIsNotEmitted() throws VerificationException + { + OutputValidator validator = unpack( "/surefire-1614-stream-corruption" ) + .executeTest() + .verifyErrorFree( 1 ); + + List lines = validator.loadLogLines( startsWith( "[WARNING] Corrupted STDOUT by directly writing to native stream in forked JVM" ) ); + + assertThat( lines ) + .hasSize( 0 ); + } +} diff --git a/surefire-its/src/test/resources/surefire-1614-stream-corruption/pom.xml b/surefire-its/src/test/resources/surefire-1614-stream-corruption/pom.xml new file mode 100644 index 0000000000..adab6e75d8 --- /dev/null +++ b/surefire-its/src/test/resources/surefire-1614-stream-corruption/pom.xml @@ -0,0 +1,35 @@ + + + 4.0.0 + org.apache.maven.plugins.surefire + junit-platform-1.0.0 + 1.0 + [SUREFIRE-1614] JUnit 5: Vintage Output Stream Corruption + + + UTF-8 + 1.8 + 1.8 + + + + + org.junit.vintage + junit-vintage-engine + 5.3.2 + test + + + + + + + org.apache.maven.plugins + maven-surefire-plugin + ${surefire.version} + + + + + diff --git a/surefire-its/src/test/resources/surefire-1614-stream-corruption/src/test/java/com/example/demo/CustomRunner.java b/surefire-its/src/test/resources/surefire-1614-stream-corruption/src/test/java/com/example/demo/CustomRunner.java new file mode 100644 index 0000000000..ea9340eaaf --- /dev/null +++ b/surefire-its/src/test/resources/surefire-1614-stream-corruption/src/test/java/com/example/demo/CustomRunner.java @@ -0,0 +1,19 @@ +package com.example.demo; + +import org.junit.runners.BlockJUnit4ClassRunner; +import org.junit.runners.model.InitializationError; +import org.junit.runners.model.TestClass; + +public class CustomRunner extends BlockJUnit4ClassRunner { + + public CustomRunner(Class klass) throws InitializationError { + super(klass); + } + + @Override + protected TestClass createTestClass(Class testClass) { + System.out.println("Creating test class"); + return super.createTestClass(testClass); + } + +} diff --git a/surefire-its/src/test/resources/surefire-1614-stream-corruption/src/test/java/com/example/demo/SurefireStreamCorruptionTest.java b/surefire-its/src/test/resources/surefire-1614-stream-corruption/src/test/java/com/example/demo/SurefireStreamCorruptionTest.java new file mode 100644 index 0000000000..ea82c83a73 --- /dev/null +++ b/surefire-its/src/test/resources/surefire-1614-stream-corruption/src/test/java/com/example/demo/SurefireStreamCorruptionTest.java @@ -0,0 +1,13 @@ +package com.example.demo; + +import org.junit.Test; +import org.junit.runner.RunWith; + +@RunWith(CustomRunner.class) +public class SurefireStreamCorruptionTest { + + @Test + public void contextLoads() { + } + +}