From fc412185093fcb24430191c4697e3217f822a967 Mon Sep 17 00:00:00 2001 From: Michael Osipov Date: Mon, 25 Dec 2023 18:37:42 +0100 Subject: [PATCH] [MPLUGIN-498] Move section rendering to separate methods This closes #248 --- .../plugin/report/PluginOverviewRenderer.java | 27 ++++++++++++------- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/maven-plugin-report-plugin/src/main/java/org/apache/maven/plugin/plugin/report/PluginOverviewRenderer.java b/maven-plugin-report-plugin/src/main/java/org/apache/maven/plugin/plugin/report/PluginOverviewRenderer.java index 5189357e..478fa6e3 100644 --- a/maven-plugin-report-plugin/src/main/java/org/apache/maven/plugin/plugin/report/PluginOverviewRenderer.java +++ b/maven-plugin-report-plugin/src/main/java/org/apache/maven/plugin/plugin/report/PluginOverviewRenderer.java @@ -87,15 +87,28 @@ protected void renderBody() { return; } - paragraph(getI18nString("goals.intro")); - boolean hasMavenReport = false; for (MojoDescriptor mojo : pluginDescriptor.getMojos()) { if (PluginUtils.isMavenReport(mojo.getImplementation(), project)) { hasMavenReport = true; + break; } } + renderGoalsSection(hasMavenReport); + + renderSystemRequirementsSection(); + + renderRequirementsHistoriesSection(); + + renderUsageSection(hasMavenReport); + + endSection(); + } + + private void renderGoalsSection(boolean hasMavenReport) { + paragraph(getI18nString("goals.intro")); + startTable(); String goalColumnName = getI18nString("goals.column.goal"); @@ -144,7 +157,9 @@ protected void renderBody() { } endTable(); + } + private void renderSystemRequirementsSection() { startSection(getI18nString("systemrequirements")); paragraph(getI18nString("systemrequirements.intro")); @@ -166,15 +181,9 @@ protected void renderBody() { endTable(); endSection(); - - renderRequirementsHistories(); - - renderUsageSection(hasMavenReport); - - endSection(); } - private void renderRequirementsHistories() { + private void renderRequirementsHistoriesSection() { if (requirementsHistories.isEmpty()) { return; }