[MJARSIGNER-48] Mark verify and sign Mojos thread safe #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be nice to see this. |
|
It would be really nice, I hate the warnings... |
|
Looking forward to this |
1 similar comment
|
Looking forward to this |
|
This would be nice to have |
|
It would really be nice to omit this unnecessary warning. |
slachiewicz
approved these changes
Jan 31, 2022
|
+1 |
1 similar comment
|
+1 |
|
@slachiewicz When will this change be merged into the master? |
elharo
changed the title
|
Needs to be updated to current master |
|
Feel free to redo/rebase this. If no one else does it, I might do it next week to celebrate the 5 year anniversary of this pull request. |
The Mojos are safe in the context of Maven 3 parallel builds. However running multiple Maven builds on the same signables might cause problems, but this is not something that should be covered.
lasselindqvist
force-pushed
the
threadsafe
branch
from
fa9ce14
to
7a0570e
Compare
|
It was one day late, but rebased and should be mergeable now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements MJARSIGNER-48.
The Mojos are safe in the context of Maven 3 parallel builds. However running multiple Maven builds on the same signables might cause problems, but this is not something that should be covered.