From 627fa4f684866a579f2c105fcc1dbf3ed776daa8 Mon Sep 17 00:00:00 2001 From: Michael Osipov Date: Sat, 13 Aug 2022 20:49:01 +0200 Subject: [PATCH] [MCHECKSTYLE-417] Upgrade Maven Reporting API to 3.1.1/Maven Reporting Impl to 3.2.0 This plugin hasn't been touched testwise for a very long time. The testing approach from MPIR has been applied to accommodate M-R-Impl 3.2.0 and future versions of it. The negative effect is that the parameter 'encoding' has duplicated 'inputEncoding' from AbstractMavenReport for a long time. For the sake of consistency it has been replaced with 'inputEncoding' which breaks backward compatibility. Users are advised to use ${project.build.sourceEncoding} anyway. This also upgrades for ITs: * Maven Site Plugin to 3.12.1 * Maven JXR Plugin to 3.3.0 This closes #87 --- pom.xml | 92 +++++++--- src/it/MCHECKSTYLE-129/pom.xml | 11 +- src/it/MCHECKSTYLE-131/pom.xml | 4 +- src/it/MCHECKSTYLE-137/pom.xml | 6 +- src/it/MCHECKSTYLE-169/pom.xml | 3 +- src/it/MCHECKSTYLE-172/pom.xml | 6 +- src/it/MCHECKSTYLE-173-with-charset/pom.xml | 2 +- .../MCHECKSTYLE-173-without-charset/pom.xml | 2 +- src/it/MCHECKSTYLE-193/pom.xml | 10 +- .../pom.xml | 2 +- .../pom.xml | 2 +- src/it/MCHECKSTYLE-222-no-resources/pom.xml | 4 +- src/it/MCHECKSTYLE-222-resources/pom.xml | 4 +- src/it/MCHECKSTYLE-222-testResources/pom.xml | 4 +- src/it/MCHECKSTYLE-224/pom.xml | 2 +- .../MCHECKSTYLE-225-LICENSE.txt/core/pom.xml | 116 ++++++------ .../MCHECKSTYLE-225-customHeader/core/pom.xml | 2 +- .../core/pom.xml | 114 ++++++------ .../MCHECKSTYLE-225-pluginManagement/pom.xml | 92 +++++----- src/it/MCHECKSTYLE-268/pom.xml | 2 +- src/it/MCHECKSTYLE-332_cache-checker/pom.xml | 2 +- src/it/MCHECKSTYLE-337/pom.xml | 2 +- src/it/MCHECKSTYLE-338/pom.xml | 2 +- src/it/MCHECKSTYLE-347/pom.xml | 2 +- .../pom.xml | 4 +- src/it/MCHECKSTYLE-357/pom.xml | 4 +- src/it/MCHECKSTYLE-365/pom.xml | 4 +- .../pom.xml | 10 +- src/it/MCHECKSTYLE-99/pom.xml | 10 +- src/it/check-fail/pom.xml | 2 +- src/it/check-pass/pom.xml | 2 +- src/it/check-tests-only/pom.xml | 2 +- src/it/checkstyle-goal/pom.xml | 4 +- src/it/checkstyle-report/pom.xml | 4 +- src/it/minimal-pom/pom.xml | 2 +- .../multi-modules-aggregate/child-a/pom.xml | 4 +- src/it/multi-modules-aggregate/pom.xml | 6 +- .../multi-modules/multi-modules-child/pom.xml | 4 +- src/it/multi-modules/pom.xml | 6 +- src/it/multimoduleproject/pom.xml | 2 +- .../checkstyle/AbstractCheckstyleReport.java | 23 +-- .../checkstyle/CheckstyleAggregateReport.java | 2 +- .../plugins/checkstyle/CheckstyleReport.java | 8 +- .../CheckstyleViolationCheckMojo.java | 24 +-- .../AbstractCheckstyleTestCase.java | 168 ++++++++++++++++++ .../checkstyle/CheckstyleReportTest.java | 142 +++++---------- .../CheckstyleViolationCheckMojoTest.java | 31 ++-- .../DependencyArtifactStubFactory.java | 69 +++++++ .../stubs/CheckstyleProjectStub.java | 42 +++++ .../checkstyle/stubs/MinMavenProjectStub.java | 2 +- .../stubs/ModuleMavenProjectStub.java | 2 +- .../stubs/MultiMavenProjectStub.java | 2 +- .../plugin-configs/check-plugin-config.xml | 2 +- .../check-plugin-plain-output.xml | 2 +- .../plugin-configs/custom-plugin-config.xml | 7 +- ...dep-resolution-exception-plugin-config.xml | 3 +- .../fail-on-error-plugin-config.xml | 2 +- .../plugin-configs/min-plugin-config.xml | 7 +- .../plugin-configs/multi-plugin-config.xml | 2 +- .../plugin-configs/no-files-plugin-config.xml | 7 +- .../plugin-configs/no-rules-plugin-config.xml | 7 +- .../no-severity-plugin-config.xml | 7 +- .../no-source-plugin-config.xml | 6 +- .../test-source-directory-plugin-config.xml | 7 +- .../plugin-configs/useFile-plugin-config.xml | 7 +- 65 files changed, 702 insertions(+), 437 deletions(-) create mode 100644 src/test/java/org/apache/maven/plugins/checkstyle/AbstractCheckstyleTestCase.java create mode 100644 src/test/java/org/apache/maven/plugins/checkstyle/DependencyArtifactStubFactory.java create mode 100644 src/test/java/org/apache/maven/plugins/checkstyle/stubs/CheckstyleProjectStub.java rename src/test/{ => resources}/plugin-configs/check-plugin-config.xml (99%) rename src/test/{ => resources}/plugin-configs/check-plugin-plain-output.xml (97%) rename src/test/{ => resources}/plugin-configs/custom-plugin-config.xml (90%) rename src/test/{ => resources}/plugin-configs/dep-resolution-exception-plugin-config.xml (95%) rename src/test/{ => resources}/plugin-configs/fail-on-error-plugin-config.xml (97%) rename src/test/{ => resources}/plugin-configs/min-plugin-config.xml (90%) rename src/test/{ => resources}/plugin-configs/multi-plugin-config.xml (97%) rename src/test/{ => resources}/plugin-configs/no-files-plugin-config.xml (90%) rename src/test/{ => resources}/plugin-configs/no-rules-plugin-config.xml (90%) rename src/test/{ => resources}/plugin-configs/no-severity-plugin-config.xml (90%) rename src/test/{ => resources}/plugin-configs/no-source-plugin-config.xml (92%) rename src/test/{ => resources}/plugin-configs/test-source-directory-plugin-config.xml (90%) rename src/test/{ => resources}/plugin-configs/useFile-plugin-config.xml (90%) diff --git a/pom.xml b/pom.xml index ae15401f..910c8b6a 100644 --- a/pom.xml +++ b/pom.xml @@ -1,4 +1,4 @@ - + + + org.apache.maven.reporting + maven-reporting-api + 3.1.1 + org.apache.maven.reporting maven-reporting-impl - 3.1.0 - - - org.apache.maven.doxia - * - - + 3.2.0 org.apache.maven.doxia - doxia-site-renderer + doxia-sink-api ${doxiaVersion} - - - plexus-container-default - org.codehaus.plexus - - org.apache.maven.doxia - doxia-integration-tools + doxia-core ${doxiaVersion} + + org.apache.maven.doxia + doxia-integration-tools + ${doxiaSitetoolsVersion} + @@ -168,11 +168,6 @@ under the License. plexus-utils 3.4.2 - - org.codehaus.plexus - plexus-interpolation - 1.26 - org.codehaus.plexus plexus-velocity @@ -208,17 +203,65 @@ under the License. + + org.codehaus.plexus + plexus-container-default + 2.1.1 + test + junit junit 4.13.2 test + + org.slf4j + slf4j-simple + 1.7.36 + test + org.apache.maven.plugin-testing maven-plugin-testing-harness 3.3.0 test + + + org.codehaus.plexus + plexus-container-default + + + + + org.eclipse.aether + aether-api + ${aetherVersion} + test + + + org.eclipse.aether + aether-impl + ${aetherVersion} + test + + + org.eclipse.aether + aether-connector-basic + ${aetherVersion} + test + + + org.eclipse.aether + aether-transport-wagon + ${aetherVersion} + test + + + org.apache.maven.wagon + wagon-http-lightweight + 3.5.1 + test org.apache.maven @@ -335,6 +378,7 @@ under the License. + org.apache.maven.plugins maven-invoker-plugin @@ -376,7 +420,7 @@ under the License. - + jdk9 diff --git a/src/it/MCHECKSTYLE-129/pom.xml b/src/it/MCHECKSTYLE-129/pom.xml index 33079a33..7d3f51b3 100644 --- a/src/it/MCHECKSTYLE-129/pom.xml +++ b/src/it/MCHECKSTYLE-129/pom.xml @@ -25,9 +25,6 @@ under the License. 1.0-SNAPSHOT checkstyle-new http://maven.apache.org - - @pom.version@ - junit @@ -46,16 +43,16 @@ under the License. org.apache.maven.plugins maven-checkstyle-plugin - ${checkstyleVersion} - + @project.version@ + - + org.apache.maven.plugins maven-checkstyle-plugin - ${checkstyleVersion} + @project.version@ https://raw.githubusercontent.com/checkstyle/checkstyle/checkstyle-8.28/src/main/resources/sun_checks.xml diff --git a/src/it/MCHECKSTYLE-131/pom.xml b/src/it/MCHECKSTYLE-131/pom.xml index 0e0409d6..54209626 100644 --- a/src/it/MCHECKSTYLE-131/pom.xml +++ b/src/it/MCHECKSTYLE-131/pom.xml @@ -43,11 +43,11 @@ under the License. org.apache.maven.plugins maven-checkstyle-plugin - @pom.version@ + @project.version@ checkstyle.xml - \ No newline at end of file + diff --git a/src/it/MCHECKSTYLE-137/pom.xml b/src/it/MCHECKSTYLE-137/pom.xml index 7050b4de..c30b6fc3 100644 --- a/src/it/MCHECKSTYLE-137/pom.xml +++ b/src/it/MCHECKSTYLE-137/pom.xml @@ -37,17 +37,13 @@ org.apache.maven.plugins maven-checkstyle-plugin - @pom.version@ - - UTF-8 - + @project.version@ validate validate checkstyle.xml - UTF-8 true true false diff --git a/src/it/MCHECKSTYLE-169/pom.xml b/src/it/MCHECKSTYLE-169/pom.xml index abfa9e7c..d1da4623 100644 --- a/src/it/MCHECKSTYLE-169/pom.xml +++ b/src/it/MCHECKSTYLE-169/pom.xml @@ -31,7 +31,6 @@ under the License. UTF-8 - @project.version@ @@ -41,7 +40,7 @@ under the License. true org.apache.maven.plugins maven-checkstyle-plugin - ${checkstyleVersion} + @project.version@ true diff --git a/src/it/MCHECKSTYLE-172/pom.xml b/src/it/MCHECKSTYLE-172/pom.xml index e29f7c62..8a8a2bb8 100644 --- a/src/it/MCHECKSTYLE-172/pom.xml +++ b/src/it/MCHECKSTYLE-172/pom.xml @@ -40,13 +40,13 @@ org.apache.maven.plugins maven-checkstyle-plugin - @pom.version@ + @project.version@ org.apache.maven.plugins maven-site-plugin @sitePluginVersion@ - + @@ -55,7 +55,7 @@ org.apache.maven.plugins maven-checkstyle-plugin - @pom.version@ + @project.version@ diff --git a/src/it/MCHECKSTYLE-173-with-charset/pom.xml b/src/it/MCHECKSTYLE-173-with-charset/pom.xml index fefa985f..b3366885 100644 --- a/src/it/MCHECKSTYLE-173-with-charset/pom.xml +++ b/src/it/MCHECKSTYLE-173-with-charset/pom.xml @@ -47,7 +47,7 @@ org.apache.maven.plugins maven-checkstyle-plugin - @pom.version@ + @project.version@ checkstyle-with-charset.xml diff --git a/src/it/MCHECKSTYLE-173-without-charset/pom.xml b/src/it/MCHECKSTYLE-173-without-charset/pom.xml index eaf6c581..7a042acb 100644 --- a/src/it/MCHECKSTYLE-173-without-charset/pom.xml +++ b/src/it/MCHECKSTYLE-173-without-charset/pom.xml @@ -47,7 +47,7 @@ org.apache.maven.plugins maven-checkstyle-plugin - @pom.version@ + @project.version@ checkstyle-without-charset.xml diff --git a/src/it/MCHECKSTYLE-193/pom.xml b/src/it/MCHECKSTYLE-193/pom.xml index 0b93fbb3..37cce0cd 100644 --- a/src/it/MCHECKSTYLE-193/pom.xml +++ b/src/it/MCHECKSTYLE-193/pom.xml @@ -37,13 +37,11 @@ org.apache.maven.plugins maven-checkstyle-plugin - @pom.version@ + @project.version@ - UTF-8 - checkstyle.xml - UTF-8 - true - true + checkstyle.xml + true + true diff --git a/src/it/MCHECKSTYLE-219-no-license_failure/pom.xml b/src/it/MCHECKSTYLE-219-no-license_failure/pom.xml index fc38b6cd..b2cd4118 100644 --- a/src/it/MCHECKSTYLE-219-no-license_failure/pom.xml +++ b/src/it/MCHECKSTYLE-219-no-license_failure/pom.xml @@ -40,7 +40,7 @@ org.apache.maven.plugins maven-checkstyle-plugin - @pom.version@ + @project.version@ check diff --git a/src/it/MCHECKSTYLE-219-no-license_success/pom.xml b/src/it/MCHECKSTYLE-219-no-license_success/pom.xml index 5159d799..2cf51cc2 100644 --- a/src/it/MCHECKSTYLE-219-no-license_success/pom.xml +++ b/src/it/MCHECKSTYLE-219-no-license_success/pom.xml @@ -40,7 +40,7 @@ org.apache.maven.plugins maven-checkstyle-plugin - @pom.version@ + @project.version@ check diff --git a/src/it/MCHECKSTYLE-222-no-resources/pom.xml b/src/it/MCHECKSTYLE-222-no-resources/pom.xml index 1b6e4639..b4541e66 100644 --- a/src/it/MCHECKSTYLE-222-no-resources/pom.xml +++ b/src/it/MCHECKSTYLE-222-no-resources/pom.xml @@ -31,7 +31,7 @@ org.apache.maven.plugins maven-checkstyle-plugin - @pom.version@ + @project.version@ @@ -42,7 +42,7 @@ org.apache.maven.plugins maven-checkstyle-plugin - @pom.version@ + @project.version@ diff --git a/src/it/MCHECKSTYLE-222-resources/pom.xml b/src/it/MCHECKSTYLE-222-resources/pom.xml index c8f486ba..3263bade 100644 --- a/src/it/MCHECKSTYLE-222-resources/pom.xml +++ b/src/it/MCHECKSTYLE-222-resources/pom.xml @@ -31,7 +31,7 @@ org.apache.maven.plugins maven-checkstyle-plugin - @pom.version@ + @project.version@ @@ -42,7 +42,7 @@ org.apache.maven.plugins maven-checkstyle-plugin - @pom.version@ + @project.version@ diff --git a/src/it/MCHECKSTYLE-222-testResources/pom.xml b/src/it/MCHECKSTYLE-222-testResources/pom.xml index 0da43182..e0022361 100644 --- a/src/it/MCHECKSTYLE-222-testResources/pom.xml +++ b/src/it/MCHECKSTYLE-222-testResources/pom.xml @@ -31,7 +31,7 @@ org.apache.maven.plugins maven-checkstyle-plugin - @pom.version@ + @project.version@ @@ -42,7 +42,7 @@ org.apache.maven.plugins maven-checkstyle-plugin - @pom.version@ + @project.version@ diff --git a/src/it/MCHECKSTYLE-224/pom.xml b/src/it/MCHECKSTYLE-224/pom.xml index fc572620..98125480 100644 --- a/src/it/MCHECKSTYLE-224/pom.xml +++ b/src/it/MCHECKSTYLE-224/pom.xml @@ -39,7 +39,7 @@ under the License. org.apache.maven.plugins maven-jxr-plugin - 2.4 + @jxrPluginVersion@ org.apache.maven.plugins diff --git a/src/it/MCHECKSTYLE-225-LICENSE.txt/core/pom.xml b/src/it/MCHECKSTYLE-225-LICENSE.txt/core/pom.xml index 189c2b57..ab68edc0 100644 --- a/src/it/MCHECKSTYLE-225-LICENSE.txt/core/pom.xml +++ b/src/it/MCHECKSTYLE-225-LICENSE.txt/core/pom.xml @@ -1,58 +1,58 @@ - - - - - 4.0.0 - - org.apache.maven.plugins.checkstyle - mcheckstyle-225-core - 1.0-SNAPSHOT - - - UTF-8 - - - - - - org.apache.maven.plugins - maven-checkstyle-plugin - @pom.version@ - - - ${project.groupId} - mcheckstyle-225-build-tools - ${project.version} - - - - - check - - check - - - - - - - + + + + + 4.0.0 + + org.apache.maven.plugins.checkstyle + mcheckstyle-225-core + 1.0-SNAPSHOT + + + UTF-8 + + + + + + org.apache.maven.plugins + maven-checkstyle-plugin + @project.version@ + + + ${project.groupId} + mcheckstyle-225-build-tools + ${project.version} + + + + + check + + check + + + + + + + diff --git a/src/it/MCHECKSTYLE-225-customHeader/core/pom.xml b/src/it/MCHECKSTYLE-225-customHeader/core/pom.xml index f342d3ad..4ea23168 100644 --- a/src/it/MCHECKSTYLE-225-customHeader/core/pom.xml +++ b/src/it/MCHECKSTYLE-225-customHeader/core/pom.xml @@ -36,7 +36,7 @@ org.apache.maven.plugins maven-checkstyle-plugin - @pom.version@ + @project.version@ ${project.groupId} diff --git a/src/it/MCHECKSTYLE-225-pluginManagement/core/pom.xml b/src/it/MCHECKSTYLE-225-pluginManagement/core/pom.xml index 4544068d..7fe36661 100644 --- a/src/it/MCHECKSTYLE-225-pluginManagement/core/pom.xml +++ b/src/it/MCHECKSTYLE-225-pluginManagement/core/pom.xml @@ -1,57 +1,57 @@ - - - - - 4.0.0 - - - org.apache.maven.plugins.checkstyle - mcheckstyle-225 - 1.0-SNAPSHOT - - mcheckstyle-225-core - - - UTF-8 - - - - - - org.apache.maven.plugins - maven-checkstyle-plugin - @pom.version@ - - - check - - check - - - - - test/custom-header.txt - - - - - + + + + + 4.0.0 + + + org.apache.maven.plugins.checkstyle + mcheckstyle-225 + 1.0-SNAPSHOT + + mcheckstyle-225-core + + + UTF-8 + + + + + + org.apache.maven.plugins + maven-checkstyle-plugin + @project.version@ + + + check + + check + + + + + test/custom-header.txt + + + + + diff --git a/src/it/MCHECKSTYLE-225-pluginManagement/pom.xml b/src/it/MCHECKSTYLE-225-pluginManagement/pom.xml index 12b0bdfd..f61ae9e7 100644 --- a/src/it/MCHECKSTYLE-225-pluginManagement/pom.xml +++ b/src/it/MCHECKSTYLE-225-pluginManagement/pom.xml @@ -1,46 +1,46 @@ - - - - - 4.0.0 - - org.apache.maven.plugins.checkstyle - mcheckstyle-225 - 1.0-SNAPSHOT - pom - - - - - - org.apache.maven.plugins - maven-checkstyle-plugin - @pom.version@ - - - ${project.groupId} - mcheckstyle-225-build-tools - ${project.version} - - - - - - - - - build-tools - core - - + + + + + 4.0.0 + + org.apache.maven.plugins.checkstyle + mcheckstyle-225 + 1.0-SNAPSHOT + pom + + + + + + org.apache.maven.plugins + maven-checkstyle-plugin + @project.version@ + + + ${project.groupId} + mcheckstyle-225-build-tools + ${project.version} + + + + + + + + + build-tools + core + + diff --git a/src/it/MCHECKSTYLE-268/pom.xml b/src/it/MCHECKSTYLE-268/pom.xml index 8a152b30..4af529b7 100644 --- a/src/it/MCHECKSTYLE-268/pom.xml +++ b/src/it/MCHECKSTYLE-268/pom.xml @@ -34,7 +34,7 @@ org.apache.maven.plugins maven-checkstyle-plugin - @pom.version@ + @project.version@ check diff --git a/src/it/MCHECKSTYLE-332_cache-checker/pom.xml b/src/it/MCHECKSTYLE-332_cache-checker/pom.xml index 388aaa84..2e4713fb 100644 --- a/src/it/MCHECKSTYLE-332_cache-checker/pom.xml +++ b/src/it/MCHECKSTYLE-332_cache-checker/pom.xml @@ -41,7 +41,7 @@ org.apache.maven.plugins maven-checkstyle-plugin - @pom.version@ + @project.version@ diff --git a/src/it/MCHECKSTYLE-337/pom.xml b/src/it/MCHECKSTYLE-337/pom.xml index 3dbbf1a5..29ffd169 100644 --- a/src/it/MCHECKSTYLE-337/pom.xml +++ b/src/it/MCHECKSTYLE-337/pom.xml @@ -40,7 +40,7 @@ org.apache.maven.plugins maven-checkstyle-plugin - @pom.version@ + @project.version@ check diff --git a/src/it/MCHECKSTYLE-338/pom.xml b/src/it/MCHECKSTYLE-338/pom.xml index dcfc9798..3ecd7f0e 100644 --- a/src/it/MCHECKSTYLE-338/pom.xml +++ b/src/it/MCHECKSTYLE-338/pom.xml @@ -33,7 +33,7 @@ maven-checkstyle-plugin - @pom.version@ + @project.version@ checkstyle.xml diff --git a/src/it/MCHECKSTYLE-347/pom.xml b/src/it/MCHECKSTYLE-347/pom.xml index 445012a5..6f1237ab 100644 --- a/src/it/MCHECKSTYLE-347/pom.xml +++ b/src/it/MCHECKSTYLE-347/pom.xml @@ -36,7 +36,7 @@ org.apache.maven.plugins maven-checkstyle-plugin - @pom.version@ + @project.version@ checkstyle.xml diff --git a/src/it/MCHECKSTYLE-357-with-header-override/pom.xml b/src/it/MCHECKSTYLE-357-with-header-override/pom.xml index 6a0d9906..9a11d16f 100644 --- a/src/it/MCHECKSTYLE-357-with-header-override/pom.xml +++ b/src/it/MCHECKSTYLE-357-with-header-override/pom.xml @@ -33,11 +33,11 @@ maven-site-plugin - 3.7.1 + @sitePluginVersion@ maven-checkstyle-plugin - @pom.version@ + @project.version@ diff --git a/src/it/MCHECKSTYLE-357/pom.xml b/src/it/MCHECKSTYLE-357/pom.xml index 4ac7dc9b..3e809bfc 100644 --- a/src/it/MCHECKSTYLE-357/pom.xml +++ b/src/it/MCHECKSTYLE-357/pom.xml @@ -33,11 +33,11 @@ maven-site-plugin - 3.7.1 + @sitePluginVersion@ maven-checkstyle-plugin - @pom.version@ + @project.version@ diff --git a/src/it/MCHECKSTYLE-365/pom.xml b/src/it/MCHECKSTYLE-365/pom.xml index 2f829d24..d1d6729b 100644 --- a/src/it/MCHECKSTYLE-365/pom.xml +++ b/src/it/MCHECKSTYLE-365/pom.xml @@ -33,11 +33,11 @@ maven-site-plugin - 3.7.1 + @sitePluginVersion@ maven-checkstyle-plugin - @pom.version@ + @project.version@ diff --git a/src/it/MCHECKSTYLE-99-custom-xref-test-location/pom.xml b/src/it/MCHECKSTYLE-99-custom-xref-test-location/pom.xml index 2c3839fa..f5f86646 100644 --- a/src/it/MCHECKSTYLE-99-custom-xref-test-location/pom.xml +++ b/src/it/MCHECKSTYLE-99-custom-xref-test-location/pom.xml @@ -25,10 +25,6 @@ under the License. 1.0-SNAPSHOT checkstyle-new http://maven.apache.org - - @pom.version@ - 3.0.0 - junit @@ -43,7 +39,7 @@ under the License. org.apache.maven.plugins maven-checkstyle-plugin - @pom.version@ + @project.version@ https://raw.githubusercontent.com/checkstyle/checkstyle/checkstyle-8.28/src/main/resources/sun_checks.xml true @@ -53,10 +49,10 @@ under the License. org.apache.maven.plugins maven-jxr-plugin - ${jxrPluginVersion} + @jxrPluginVersion@ - + diff --git a/src/it/MCHECKSTYLE-99/pom.xml b/src/it/MCHECKSTYLE-99/pom.xml index 450f13cd..bf629fd6 100644 --- a/src/it/MCHECKSTYLE-99/pom.xml +++ b/src/it/MCHECKSTYLE-99/pom.xml @@ -25,10 +25,6 @@ under the License. 1.0-SNAPSHOT checkstyle-new http://maven.apache.org - - @pom.version@ - 3.0.0 - junit @@ -43,7 +39,7 @@ under the License. org.apache.maven.plugins maven-checkstyle-plugin - @pom.version@ + @project.version@ https://raw.githubusercontent.com/checkstyle/checkstyle/checkstyle-8.28/src/main/resources/sun_checks.xml true @@ -52,10 +48,10 @@ under the License. org.apache.maven.plugins maven-jxr-plugin - ${jxrPluginVersion} + @jxrPluginVersion@ - + diff --git a/src/it/check-fail/pom.xml b/src/it/check-fail/pom.xml index ebf692b1..a7e6de42 100644 --- a/src/it/check-fail/pom.xml +++ b/src/it/check-fail/pom.xml @@ -40,7 +40,7 @@ org.apache.maven.plugins maven-checkstyle-plugin - @pom.version@ + @project.version@ check diff --git a/src/it/check-pass/pom.xml b/src/it/check-pass/pom.xml index a2303f94..532139ce 100644 --- a/src/it/check-pass/pom.xml +++ b/src/it/check-pass/pom.xml @@ -45,7 +45,7 @@ org.apache.maven.plugins maven-checkstyle-plugin - @pom.version@ + @project.version@ check diff --git a/src/it/check-tests-only/pom.xml b/src/it/check-tests-only/pom.xml index d377267c..b56faa2d 100644 --- a/src/it/check-tests-only/pom.xml +++ b/src/it/check-tests-only/pom.xml @@ -31,7 +31,7 @@ org.apache.maven.plugins maven-checkstyle-plugin - @pom.version@ + @project.version@ **/*.* true diff --git a/src/it/checkstyle-goal/pom.xml b/src/it/checkstyle-goal/pom.xml index 821dcb22..373425c3 100644 --- a/src/it/checkstyle-goal/pom.xml +++ b/src/it/checkstyle-goal/pom.xml @@ -40,7 +40,7 @@ org.apache.maven.plugins maven-checkstyle-plugin - @pom.version@ + @project.version@ true @@ -53,7 +53,7 @@ org.apache.maven.plugins maven-checkstyle-plugin - @pom.version@ + @project.version@ diff --git a/src/it/checkstyle-report/pom.xml b/src/it/checkstyle-report/pom.xml index 686c43cf..9755cab7 100644 --- a/src/it/checkstyle-report/pom.xml +++ b/src/it/checkstyle-report/pom.xml @@ -40,7 +40,7 @@ org.apache.maven.plugins maven-checkstyle-plugin - @pom.version@ + @project.version@ org.apache.maven.plugins @@ -55,7 +55,7 @@ org.apache.maven.plugins maven-checkstyle-plugin - @pom.version@ + @project.version@ true diff --git a/src/it/minimal-pom/pom.xml b/src/it/minimal-pom/pom.xml index 11f77810..d30a26ac 100644 --- a/src/it/minimal-pom/pom.xml +++ b/src/it/minimal-pom/pom.xml @@ -49,7 +49,7 @@ org.apache.maven.plugins maven-checkstyle-plugin - @pom.version@ + @project.version@ diff --git a/src/it/multi-modules-aggregate/child-a/pom.xml b/src/it/multi-modules-aggregate/child-a/pom.xml index 94839244..973a8f60 100644 --- a/src/it/multi-modules-aggregate/child-a/pom.xml +++ b/src/it/multi-modules-aggregate/child-a/pom.xml @@ -43,7 +43,7 @@ under the License. org.apache.maven.plugins maven-checkstyle-plugin - @pom.version@ + @project.version@ @@ -56,7 +56,7 @@ under the License. org.apache.maven.plugins maven-checkstyle-plugin - @pom.version@ + @project.version@ diff --git a/src/it/multi-modules-aggregate/pom.xml b/src/it/multi-modules-aggregate/pom.xml index 82ac112d..c97e517b 100644 --- a/src/it/multi-modules-aggregate/pom.xml +++ b/src/it/multi-modules-aggregate/pom.xml @@ -37,7 +37,7 @@ org.apache.maven.plugins maven-checkstyle-plugin - @pom.version@ + @project.version@ @@ -50,7 +50,7 @@ org.apache.maven.plugins maven-checkstyle-plugin - @pom.version@ + @project.version@ @@ -61,7 +61,7 @@ org.apache.maven.plugins maven-checkstyle-plugin - @pom.version@ + @project.version@ maven_checks.xml diff --git a/src/it/multi-modules/multi-modules-child/pom.xml b/src/it/multi-modules/multi-modules-child/pom.xml index 0cd429c6..00fdde84 100644 --- a/src/it/multi-modules/multi-modules-child/pom.xml +++ b/src/it/multi-modules/multi-modules-child/pom.xml @@ -43,7 +43,7 @@ under the License. org.apache.maven.plugins maven-checkstyle-plugin - @pom.version@ + @project.version@ @@ -56,7 +56,7 @@ under the License. org.apache.maven.plugins maven-checkstyle-plugin - @pom.version@ + @project.version@ diff --git a/src/it/multi-modules/pom.xml b/src/it/multi-modules/pom.xml index 1539b19c..e618dcfd 100644 --- a/src/it/multi-modules/pom.xml +++ b/src/it/multi-modules/pom.xml @@ -38,8 +38,8 @@ org.apache.maven.plugins maven-checkstyle-plugin - @pom.version@ - + @project.version@ + @@ -55,4 +55,4 @@ multi-modules-child multi-modules-child-nosource - \ No newline at end of file + diff --git a/src/it/multimoduleproject/pom.xml b/src/it/multimoduleproject/pom.xml index dff6b120..cfe9b220 100644 --- a/src/it/multimoduleproject/pom.xml +++ b/src/it/multimoduleproject/pom.xml @@ -32,7 +32,7 @@ maven-checkstyle-plugin - @pom.version@ + @project.version@ + 4.0.0 + test + test + 1.0-SNAPSHOT maven-checkstyle-plugin ${basedir}/target/test-harness/checkstyle/custom + ${localRepository} true true true @@ -44,7 +49,7 @@ under the License. ${basedir}/target/test-harness/checkstyle/custom ${basedir}/target/test-harness/checkstyle/custom - UTF-8 + UTF-8 diff --git a/src/test/plugin-configs/dep-resolution-exception-plugin-config.xml b/src/test/resources/plugin-configs/dep-resolution-exception-plugin-config.xml similarity index 95% rename from src/test/plugin-configs/dep-resolution-exception-plugin-config.xml rename to src/test/resources/plugin-configs/dep-resolution-exception-plugin-config.xml index d2c0218d..e9aa739a 100644 --- a/src/test/plugin-configs/dep-resolution-exception-plugin-config.xml +++ b/src/test/resources/plugin-configs/dep-resolution-exception-plugin-config.xml @@ -24,6 +24,7 @@ under the License. maven-checkstyle-plugin ${basedir}/target/test-harness/checkstyle/dep-resolution + ${localRepository} true true true @@ -43,7 +44,7 @@ under the License. true ${basedir}/target/site/xref ${basedir}/target/site/xref-test - UTF-8 + UTF-8 diff --git a/src/test/plugin-configs/fail-on-error-plugin-config.xml b/src/test/resources/plugin-configs/fail-on-error-plugin-config.xml similarity index 97% rename from src/test/plugin-configs/fail-on-error-plugin-config.xml rename to src/test/resources/plugin-configs/fail-on-error-plugin-config.xml index 06853a12..4090e096 100644 --- a/src/test/plugin-configs/fail-on-error-plugin-config.xml +++ b/src/test/resources/plugin-configs/fail-on-error-plugin-config.xml @@ -43,7 +43,7 @@ under the License. true ${basedir}/target/site/xref ${basedir}/target/site/xref-test - UTF-8 + UTF-8 diff --git a/src/test/plugin-configs/min-plugin-config.xml b/src/test/resources/plugin-configs/min-plugin-config.xml similarity index 90% rename from src/test/plugin-configs/min-plugin-config.xml rename to src/test/resources/plugin-configs/min-plugin-config.xml index a151bdb2..5ce4ca1a 100644 --- a/src/test/plugin-configs/min-plugin-config.xml +++ b/src/test/resources/plugin-configs/min-plugin-config.xml @@ -18,12 +18,17 @@ under the License. --> + 4.0.0 + test + test + 1.0-SNAPSHOT maven-checkstyle-plugin ${basedir}/target/test-harness/checkstyle/min + ${localRepository} true true true @@ -43,7 +48,7 @@ under the License. true ${basedir}/target/site/xref ${basedir}/target/site/xref-test - UTF-8 + UTF-8 diff --git a/src/test/plugin-configs/multi-plugin-config.xml b/src/test/resources/plugin-configs/multi-plugin-config.xml similarity index 97% rename from src/test/plugin-configs/multi-plugin-config.xml rename to src/test/resources/plugin-configs/multi-plugin-config.xml index 4f3d4f25..9bb0c059 100644 --- a/src/test/plugin-configs/multi-plugin-config.xml +++ b/src/test/resources/plugin-configs/multi-plugin-config.xml @@ -43,7 +43,7 @@ under the License. true ${basedir}/target/site/xref ${basedir}/target/site/xref-test - UTF-8 + UTF-8 diff --git a/src/test/plugin-configs/no-files-plugin-config.xml b/src/test/resources/plugin-configs/no-files-plugin-config.xml similarity index 90% rename from src/test/plugin-configs/no-files-plugin-config.xml rename to src/test/resources/plugin-configs/no-files-plugin-config.xml index ad5e125d..ce32b86f 100644 --- a/src/test/plugin-configs/no-files-plugin-config.xml +++ b/src/test/resources/plugin-configs/no-files-plugin-config.xml @@ -18,12 +18,17 @@ under the License. --> + 4.0.0 + test + test + 1.0-SNAPSHOT maven-checkstyle-plugin ${basedir}/target/test-harness/checkstyle/no-files + ${localRepository} true true false @@ -43,7 +48,7 @@ under the License. true ${basedir}/target/site/xref ${basedir}/target/site/xref-test - UTF-8 + UTF-8 diff --git a/src/test/plugin-configs/no-rules-plugin-config.xml b/src/test/resources/plugin-configs/no-rules-plugin-config.xml similarity index 90% rename from src/test/plugin-configs/no-rules-plugin-config.xml rename to src/test/resources/plugin-configs/no-rules-plugin-config.xml index b189c759..899bc84d 100644 --- a/src/test/plugin-configs/no-rules-plugin-config.xml +++ b/src/test/resources/plugin-configs/no-rules-plugin-config.xml @@ -18,12 +18,17 @@ under the License. --> + 4.0.0 + test + test + 1.0-SNAPSHOT maven-checkstyle-plugin ${basedir}/target/test-harness/checkstyle/no-rules + ${localRepository} false true true @@ -43,7 +48,7 @@ under the License. true ${basedir}/target/site/xref ${basedir}/target/site/xref-test - UTF-8 + UTF-8 diff --git a/src/test/plugin-configs/no-severity-plugin-config.xml b/src/test/resources/plugin-configs/no-severity-plugin-config.xml similarity index 90% rename from src/test/plugin-configs/no-severity-plugin-config.xml rename to src/test/resources/plugin-configs/no-severity-plugin-config.xml index 91d5fae4..416c9fc1 100644 --- a/src/test/plugin-configs/no-severity-plugin-config.xml +++ b/src/test/resources/plugin-configs/no-severity-plugin-config.xml @@ -18,12 +18,17 @@ under the License. --> + 4.0.0 + test + test + 1.0-SNAPSHOT maven-checkstyle-plugin ${basedir}/target/test-harness/checkstyle/no-severity + ${localRepository} true false true @@ -43,7 +48,7 @@ under the License. true ${basedir}/target/site/xref ${basedir}/target/site/xref-test - UTF-8 + UTF-8 diff --git a/src/test/plugin-configs/no-source-plugin-config.xml b/src/test/resources/plugin-configs/no-source-plugin-config.xml similarity index 92% rename from src/test/plugin-configs/no-source-plugin-config.xml rename to src/test/resources/plugin-configs/no-source-plugin-config.xml index 37a110ed..fab72514 100644 --- a/src/test/plugin-configs/no-source-plugin-config.xml +++ b/src/test/resources/plugin-configs/no-source-plugin-config.xml @@ -18,6 +18,10 @@ under the License. --> + 4.0.0 + test + test + 1.0-SNAPSHOT @@ -43,7 +47,7 @@ under the License. true ${basedir}/target/site/xref ${basedir}/target/site/xref-test - UTF-8 + UTF-8 diff --git a/src/test/plugin-configs/test-source-directory-plugin-config.xml b/src/test/resources/plugin-configs/test-source-directory-plugin-config.xml similarity index 90% rename from src/test/plugin-configs/test-source-directory-plugin-config.xml rename to src/test/resources/plugin-configs/test-source-directory-plugin-config.xml index 2f6defe7..4678fa4e 100644 --- a/src/test/plugin-configs/test-source-directory-plugin-config.xml +++ b/src/test/resources/plugin-configs/test-source-directory-plugin-config.xml @@ -18,12 +18,17 @@ under the License. --> + 4.0.0 + test + test + 1.0-SNAPSHOT maven-checkstyle-plugin ${basedir}/target/test-harness/checkstyle/no-source + ${localRepository} true true true @@ -46,7 +51,7 @@ under the License. true ${basedir}/target/site/xref ${basedir}/target/site/xref-test - UTF-8 + UTF-8 diff --git a/src/test/plugin-configs/useFile-plugin-config.xml b/src/test/resources/plugin-configs/useFile-plugin-config.xml similarity index 90% rename from src/test/plugin-configs/useFile-plugin-config.xml rename to src/test/resources/plugin-configs/useFile-plugin-config.xml index b488964c..89e78b4d 100644 --- a/src/test/plugin-configs/useFile-plugin-config.xml +++ b/src/test/resources/plugin-configs/useFile-plugin-config.xml @@ -18,12 +18,17 @@ under the License. --> + 4.0.0 + test + test + 1.0-SNAPSHOT maven-checkstyle-plugin ${basedir}/target/test-harness/checkstyle/useFile + ${localRepository} true true true @@ -44,7 +49,7 @@ under the License. ${basedir}/target/site/xref ${basedir}/target/site/xref-test ${basedir}/target/test-harness/checkstyle/useFile/checkstyle-output.txt - UTF-8 + UTF-8