Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lucene.Net.Analysis.Ja.Util.CSVUtil.QuoteEscape is not escaping quotes #660

Closed
NightOwl888 opened this issue Oct 15, 2022 · 1 comment · Fixed by #712
Closed

Lucene.Net.Analysis.Ja.Util.CSVUtil.QuoteEscape is not escaping quotes #660

NightOwl888 opened this issue Oct 15, 2022 · 1 comment · Fixed by #712
Assignees
@NightOwl888
Labels
hacktoberfest-accepted investigation is:bug

Comments

@NightOwl888
Copy link
Contributor

NightOwl888 commented Oct 15, 2022 •
edited
Loading

https://sonarcloud.io/project/issues?resolved=false&types=BUG&id=nikcio_lucenenet&open=AYPAuQAohbfJOGLOobtL

We should be overwriting the value of return here, but we are not.

This needs to be analyzed further by comparing against Lucene 4.8.1:

  1. If this is a bug in the translation from Java to .NET, we should simply fix it.
  2. If this is a bug that still exists in the current version of Lucene, we should both fix it and report it to them.
  3. If this is a bug that existed in 4.8.1 but was fixed since, we need to track down the JIRA/GitHub issue number and leave a comment indicating the issue number of the patch that has been applied. The entire patch should be analyzed and we should bring over all changes from the patch. We should also look up and include the Lucene version number(s) it was released in so we know when to remove the comment.
@NightOwl888 NightOwl888 added up-for-grabs This issue is open to be worked on by anyone is:bug investigation good-first-issue Good for newcomers hacktoberfest-accepted labels Oct 15, 2022
@nikcio
Copy link
Contributor

nikcio commented Oct 15, 2022

Link to issue isolated from other issues: https://sonarcloud.io/project/issues?issues=AYPAuQAohbfJOGLOobtL&open=AYPAuQAohbfJOGLOobtL&id=nikcio_lucenenet

@NightOwl888 NightOwl888 self-assigned this Oct 20, 2022
NightOwl888 added a commit to NightOwl888/lucenenet that referenced this issue Oct 20, 2022
@NightOwl888
Lucene.Net.Analysis.Kuromoji.Util.CSVUtil: Applied SOLR-9413 patch to…
6bbf927 
… fix the QuoteEscape() method and add tests. Fixes apache#660.
@NightOwl888 NightOwl888 mentioned this issue Oct 20, 2022
Merged
NightOwl888 added a commit that referenced this issue Oct 20, 2022
@NightOwl888
Lucene.Net.Analysis.Kuromoji.Util.CSVUtil: Applied SOLR-9413 patch to…
e8c49dc 
… fix the QuoteEscape() method and add tests. Fixes #660.
@NightOwl888 NightOwl888 removed up-for-grabs This issue is open to be worked on by anyone good-first-issue Good for newcomers labels Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NightOwl888 NightOwl888

Labels
hacktoberfest-accepted investigation is:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Lucene.Net.Analysis.Kuromoji.Util.CSVUtil: Fixed QuoteEscape method NightOwl888/lucenenet
2 participants
@NightOwl888 @nikcio