Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github on-commit tests on MacOS and Windows #14054

Merged
merged 5 commits into from
Dec 10, 2024
Merged

Add github on-commit tests on MacOS and Windows #14054

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0174206
Check if gh builds pass on Windows.
dweiss Dec 10, 2024
52d0d3b
Quote task times.
dweiss Dec 10, 2024
44556cf
Turn off autocrlf for git.
dweiss Dec 10, 2024
6a06b0d
Include macos and windows, correct crlf on Windows only.
dweiss Dec 10, 2024
d4e710f
Merge remote-tracking branch 'origin/main' into gh-windows-builds
dweiss Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions .github/workflows/run-checks-all.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,14 @@ jobs:
runs-on: ${{ matrix.os }}

steps:
- name: Correct git autocrlf
run: git config --global core.autocrlf false

- uses: actions/checkout@v4
- uses: ./.github/actions/prepare-for-build

- name: Run gradle check (without tests)
run: ./gradlew check -x test -Ptask.times=true --max-workers 2
run: ./gradlew check -x test "-Ptask.times=true" --max-workers 2


# This runs all tests without any other validation checks.
Expand All @@ -49,14 +52,16 @@ jobs:
strategy:
matrix:
# Operating systems to run on.
# windows-latest: fairly slow to build and results in odd errors (see LUCENE-10167)
# macos-latest: a tad slower than ubuntu and pretty much the same (?) so leaving out.
os: [ ubuntu-latest ]
os: [ ubuntu-latest, windows-latest, macos-latest ]
java: [ '21' ]

runs-on: ${{ matrix.os }}

steps:
- name: Correct git autocrlf on Windows
if: startsWith(matrix.os, 'windows')
run: git config --global core.autocrlf false

- uses: actions/checkout@v4
- uses: ./.github/actions/prepare-for-build

Expand Down
Loading