Add github on-commit tests on MacOS and Windows #14054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing check on Windows is due to #14053 - shows it's working. ;) |
rmuir
approved these changes
Dec 10, 2024
|
I thought we did have macos tests already? Maybe that is not tests, but some other task? |
|
I think distribution tests (run-checks-mod-distribution.tests.yml) run on MacOSX. Also, Uwe has his own jenkins box, which runs Windows and Mac tests (on a virtual machine). These github workers are running on real hardware though and I think it's worth keeping them. Even if they are somehow "virtualized" or sandboxed, it'll be an earlier warning sign for pull requests that something is wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some low-level APIs used now that may be surprising and behave differently on different platforms. I suggest we enable MacOS and Windows builds to have a broader coverage and earlier feedback.
Windows builds are significantly slower compared to unix-ish platforms. I don't think there is a way around it (unless somebody works at github and could arrange a higher-cpu runner ;). But since those builds are shifted to the background and don't interfere with normal dev workflow, I don't think it's such a big issue.
This said, it'd be nice to have the tests run great again...