Fix TestAssertingPointsFormat.testWithExceptions failure [LUCENE-10648]

[asfimport]

We are seeing build failures due to TestAssertingPointsFormat.testWithExceptions. I am able to repro this on my box with the random seed. Tracking the issue here.

Sample Failing Build: https://ci-builds.apache.org/job/Lucene/job/Lucene-Check-main/6057/

---

Migrated from LUCENE-10648 by Vigya Sharma (@vigyasharma), resolved Jul 19 2022
Pull requests: #1012

[asfimport]

Vigya Sharma (@vigyasharma) (migrated from JIRA)

deleteNewFiles in addIndexes fails with a NoSuchFileException. Looks like the mergeInfo gets set with some files that were created, but we are not finding them there during cleanup.

 

org.apache.lucene.tests.codecs.asserting.TestAssertingPointsFormat > testWithExceptions FAILED
    java.nio.file.NoSuchFileException: /Users/vigyas/forks/lucene/lucene/test-framework/build/tmp/tests-tmp/lucene.tests.codecs.asserting.TestAssertingPointsFormat_36B7C02E59E6453-002/tempDir-001/_0.kdm
        at __randomizedtesting.SeedInfo.seed([36B7C02E59E6453:A138E07E6A102BA9]:0)
        at java.base/sun.nio.fs.UnixException.translateToIOException(UnixException.java:92)
        at java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:106)
        at java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:111)
        at java.base/sun.nio.fs.UnixFileSystemProvider.implDelete(UnixFileSystemProvider.java:248)
        at java.base/sun.nio.fs.AbstractFileSystemProvider.delete(AbstractFileSystemProvider.java:105)
        at org.apache.lucene.tests.mockfile.FilterFileSystemProvider.delete(FilterFileSystemProvider.java:134)
        at org.apache.lucene.tests.mockfile.FilterFileSystemProvider.delete(FilterFileSystemProvider.java:134)
        at org.apache.lucene.tests.mockfile.FilterFileSystemProvider.delete(FilterFileSystemProvider.java:134)
        at org.apache.lucene.tests.mockfile.FilterFileSystemProvider.delete(FilterFileSystemProvider.java:134)
        at org.apache.lucene.tests.mockfile.FilterFileSystemProvider.delete(FilterFileSystemProvider.java:134)
        at java.base/java.nio.file.Files.delete(Files.java:1152)
        at org.apache.lucene.store.FSDirectory.privateDeleteFile(FSDirectory.java:344)
        at org.apache.lucene.store.FSDirectory.deleteFile(FSDirectory.java:309)
        at org.apache.lucene.tests.store.MockDirectoryWrapper.deleteFile(MockDirectoryWrapper.java:651)
        at org.apache.lucene.store.LockValidatingDirectoryWrapper.deleteFile(LockValidatingDirectoryWrapper.java:37)
        at org.apache.lucene.index.IndexFileDeleter.deleteFile(IndexFileDeleter.java:763)
        at org.apache.lucene.index.IndexFileDeleter.deleteFiles(IndexFileDeleter.java:757)
        at org.apache.lucene.index.IndexFileDeleter.deleteNewFiles(IndexFileDeleter.java:729)
        at org.apache.lucene.index.IndexWriter.deleteNewFiles(IndexWriter.java:5763)
        at org.apache.lucene.index.IndexWriter.addIndexes(IndexWriter.java:3177)
        at org.apache.lucene.tests.index.RandomIndexWriter.addIndexes(RandomIndexWriter.java:334)
        at org.apache.lucene.tests.index.BasePointsFormatTestCase.switchIndex(BasePointsFormatTestCase.java:1195)
        at org.apache.lucene.tests.index.BasePointsFormatTestCase.verify(BasePointsFormatTestCase.java:797)
        at org.apache.lucene.tests.index.BasePointsFormatTestCase.testWithExceptions(BasePointsFormatTestCase.java:265)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        ...
        at com.carrotsearch.randomizedtesting.ThreadLeakControl.lambda$forkTimeoutingTask$0(ThreadLeakControl.java:850)
        at java.base/java.lang.Thread.run(Thread.java:833) 

[asfimport]

ASF subversion and git services (migrated from JIRA)

Commit ca79174 in lucene's branch refs/heads/main from Vigya Sharma
https://gitbox.apache.org/repos/asf?p=lucene.git;h=ca7917472b4

LUCENE-10648: Fix failures in TestAssertingPointsFormat.testWithExceptions (#1012)

• Fix failures in TestAssertingPointsFormat.testWithExceptions

• remove redundant finally block

• tidy

• remove TODO as it is done now

[asfimport]

ASF subversion and git services (migrated from JIRA)

Commit 5dd8e9b in lucene's branch refs/heads/branch_9x from Vigya Sharma
https://gitbox.apache.org/repos/asf?p=lucene.git;h=5dd8e9bdc5a

#11253: Use MergeScheduler and MergePolicy to run addIndexes(CodecReader[]) merges. (#1051)

Use merge policy and merge scheduler to run addIndexes merges.

This is a back port of the following commits from main:

• Add concurrency to addIndexes(CodecReader…) API [LUCENE-10216] #11253: Use MergeScheduler and MergePolicy to run addIndexes(CodecReader[]) merges. (LUCENE-10216: Use MergeScheduler and MergePolicy to run addIndexes(CodecReader[]) merges. #633)
• LUCENE-10648: Fix failures in TestAssertingPointsFormat.testWithExceptions (LUCENE-10648: Fix failures in TestAssertingPointsFormat.testWithExceptions #1012)