Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable sort optimization on _doc for 8.7 release. [LUCENE-9569] #10609

Closed
asfimport opened this issue Oct 7, 2020 · 5 comments
Closed

Comments

@asfimport
Copy link

asfimport commented Oct 7, 2020

Sort optimization on _doc was introduced in #10489, but it looks unstable and lead to some recent tests failures. 

As the release of 8.7 is very soon, we need to temporarily disable this sort optimization for _doc for this release with a plan to stabilize it for later releases.


Migrated from LUCENE-9569 by Mayya Sharipova (@mayya-sharipova), resolved Nov 12 2020
Pull requests: apache/lucene-solr#1959

@asfimport
Copy link
Author

ASF subversion and git services (migrated from JIRA)

Commit 1c0f07a in lucene-solr's branch refs/heads/branch_8x from Mayya Sharipova
https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=1c0f07a

LUCENE-9569 Disalbe sort opt on _doc (#1959)

Sort optimization on _doc was introduced in PR #1856,
but it looks unstable and lead to some recent tests failure.
As the release of 8.7 is very soon, we need to temporarily
disable this sort optimization for _doc for this release
with a plan to stabilize it for later releases.

@asfimport
Copy link
Author

Adrien Grand (@jpountz) (migrated from JIRA)

@mayya-sharipova Should we add it back now?

@asfimport
Copy link
Author

Mayya Sharipova (@mayya-sharipova) (migrated from JIRA)

@jpountz Thank you for the reminder. I have reverted this commit, so sort optimization on _doc should again be enabled on branch_8x.

@asfimport
Copy link
Author

ASF subversion and git services (migrated from JIRA)

Commit e403814 in lucene-solr's branch refs/heads/branch_8x from Mayya Sharipova
https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=e403814

Revert "LUCENE-9569 Disalbe sort opt on _doc (#1959)"

Re-enabled sort optimization on _doc

This reverts commit 1c0f07a.

@asfimport
Copy link
Author

ASF subversion and git services (migrated from JIRA)

Commit e403814 in lucene-solr's branch refs/heads/branch_8x from Mayya Sharipova
https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=e403814

Revert "LUCENE-9569 Disalbe sort opt on _doc (#1959)"

Re-enabled sort optimization on _doc

This reverts commit 1c0f07a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant