[LOG4J2-3418] Fix Log4j2CloudConfigLoggingSystem registration #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppkarwasz
force-pushed
the
spring-factories
branch
from
1368c9a to
f807ecc
Compare
|
Could you add documentation how to activate this feature in future? |
This PR adds support for the `spring.factories` registration method of the `Log4j2CloudConfigLoggingSystem` to replace the old Java system properties injection method. A Log4j 2.x `log4j2.disableCloudConfigLoggingSystem` property is added to enable a choice between the `Log4j2CloudConfigLoggingSystem` and `Log4j2LoggingSystem`.
ppkarwasz
force-pushed
the
spring-factories
branch
from
f807ecc to
e247fe8
Compare
The behavior of the artifact does not change: you add it to the classpath and Spring Boot detects it. What changes is the way this is done: before Java system properties were used, so all Spring Boot applications in the JVM tried to use this plugin. After this PR only the one with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
spring.factoriesregistration method of theLog4j2CloudConfigLoggingSystemto replace the old Java system properties injection method.A Log4j 2.x
log4j2.disableCloudConfigLoggingSystemproperty is added to enable a choice between theLog4j2CloudConfigLoggingSystemandLog4j2LoggingSystem.