Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove log4j-kubernetes module #2218

Closed
ppkarwasz opened this issue Jan 19, 2024 · 1 comment
Closed

Remove log4j-kubernetes module #2218

ppkarwasz opened this issue Jan 19, 2024 · 1 comment
Assignees

Comments

@ppkarwasz
Copy link
Contributor

The log4j-kubernetes module is problematic, because:

  • the kubernetes-model-core dependency follows Kubernetes lifecycle. It might be (and it already occurred) that breaking changes occurred on a minor version change,
  • on the other hand it depends only on StrLookup, which is unlikely to ever change,
  • the Fabric8 team has a better idea, which properties could be interesting to users.

Therefore if fabric8io/kubernetes-client#5718 is accepted, I propose to remove log4j-kubernetes from our codebase.

@ppkarwasz
Copy link
Contributor Author

An improved kubernetes-log4j module is available since Kubernetes Client version 6.11.0 (cf. announcement), therefore we can remove log4j-kubernetes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant