[KYUUBI #6263] Use HiveConf.getConfVars or Hive conf names directly #6827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madhukar525722
force-pushed
the
hive4
branch
from
d9fb9c8 to
7d87234
Compare
|
@Madhukar525722 Thank you for your effort in working on upgrading Hive 4, it seems you touched both the Spark engine/plugin modules and the Hive engine module, I would say it's IMPOSSIBLE to upgrade the Spark's built-in Hive to 4 at the current stage, all Kyuubi supported Spark versions(Spark 3.2 to 3.5 and 4.0 as of today) use Hive 2.3. So I think you are focusing on upgrading the Hive engine to Hive 4, right? |
|
Thanks @pan3793 for the review. Now, I understood what I missed, I forgot about spark dependency of hive on 2.3.10 and 2.3.9. Yes, I was focusing on hive engine upgrade, I will upgrade hive jdbc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
As initial step to bring hive 4 compatibility in Kyuubi, has addressed the following incompatible changes on ConfVars enum via HIVE-27925.
apache/hive#4919
apache/hive#5107
HiveConf.getConfVars or config names is more robust way to handle this incompatibility.
How was this patch tested?
Build locally and CI
Was this patch authored or co-authored using generative AI tooling?
No