Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump log4j from 2.24.1 to 2.24.2 #6826

Closed
wants to merge 1 commit into from

Conversation

pionCham
Copy link
Contributor

@pionCham pionCham commented Nov 26, 2024

Why are the changes needed?

As @pan3793 pointed out that version 2.24.1 had critical bug in #6774 (comment)
Bump bump log4j from 2.24.1 to 2.24.2

How was this patch tested?

GA.

Was this patch authored or co-authored using generative AI tooling?

No.

@pionCham pionCham marked this pull request as draft November 26, 2024 10:44
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (27c734e) to head (150713f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6826   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         687     687           
  Lines       42445   42445           
  Branches     5793    5793           
======================================
  Misses      42445   42445           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pan3793 pan3793 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please fill in the PR template, it's already simplified

@pan3793
Copy link
Member

pan3793 commented Nov 27, 2024

Scala 2.13 test failure is irrelevant

@pionCham pionCham marked this pull request as ready for review November 28, 2024 15:44
@pionCham
Copy link
Contributor Author

LGTM, please fill in the PR template, it's already simplified

Thanks! I have completed. @pan3793

@pan3793 pan3793 added this to the v1.11.0 milestone Nov 28, 2024
@pan3793 pan3793 closed this in bfa9f2a Nov 28, 2024
@pan3793
Copy link
Member

pan3793 commented Nov 28, 2024

Thanks, merged to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants