Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[K8S] Cleanup the terminated app info trigger before clear kubernetes clients #5771

Closed
wants to merge 1 commit into from

Conversation

turboFei
Copy link
Member

@turboFei turboFei commented Nov 24, 2023

🔍 Description

When stopping KubernetesApplicationOperation, we shall cleanup the terminated app info trigger before kubernetes clients.

Because for the removalListener of cleanupTerminatedAppInfoTrigger, it need to invoke the kubernetes client to cleanup the terminated application pods.

Issue References 🔗

This pull request fixes #

Describe Your Solution 🔧

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests


Checklists

📝 Author Self Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • This patch was not authored or co-authored using Generative Tooling

📝 Committer Pre-Merge Checklist

  • Pull request title is okay.
  • No license issues.
  • Milestone correctly set?
  • Test coverage is ok
  • Assignees are selected.
  • Minimum number of approvals
  • No changes are requested

Be nice. Be informative.

@turboFei turboFei changed the title stop trigger before k8s clients [K8S] Cleanup the terminated app info trigger before kubernetes clients Nov 24, 2023
@turboFei turboFei self-assigned this Nov 24, 2023
@turboFei turboFei added this to the v1.8.1 milestone Nov 24, 2023
@turboFei turboFei requested a review from zwangsheng November 24, 2023 07:57
@turboFei turboFei changed the title [K8S] Cleanup the terminated app info trigger before kubernetes clients [K8S] Cleanup the terminated app info trigger before clear kubernetes clients Nov 24, 2023
@turboFei turboFei requested a review from pan3793 November 24, 2023 08:18
@turboFei turboFei closed this in e22a7f7 Nov 24, 2023
turboFei added a commit that referenced this pull request Nov 24, 2023
…lear kubernetes clients

# 🔍 Description

When stopping KubernetesApplicationOperation, we shall cleanup the terminated app info trigger before kubernetes clients.

Because for the `removalListener` of `cleanupTerminatedAppInfoTrigger`, it need to invoke the kubernetes client to cleanup the terminated application pods.

## Issue References 🔗

This pull request fixes #

## Describe Your Solution 🔧

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

## Types of changes 🔖

- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests

---

# Checklists
## 📝 Author Self Checklist

- [x] My code follows the [style guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html) of this project
- [ ] I have performed a self-review
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

## 📝 Committer Pre-Merge Checklist

- [x] Pull request title is okay.
- [x] No license issues.
- [x] Milestone correctly set?
- [ ] Test coverage is ok
- [x] Assignees are selected.
- [x] Minimum number of approvals
- [x] No changes are requested

**Be nice. Be informative.**

Closes #5771 from turboFei/stop_k8s_op.

Closes #5771

4b11127 [fwang12] stop trigger before k8s clients

Authored-by: fwang12 <[email protected]>
Signed-off-by: fwang12 <[email protected]>
(cherry picked from commit e22a7f7)
Signed-off-by: fwang12 <[email protected]>
cfmcgrady pushed a commit to cfmcgrady/incubator-kyuubi that referenced this pull request Dec 9, 2024
…p info trigger before clear kubernetes clients
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants