-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KYUUBI #5768][AUTHZ] Authz internal place holder should skip privilege check #5769
Conversation
ping @yaooqinn could you take a look? |
...uubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/PrivilegesBuilder.scala
Outdated
Show resolved
Hide resolved
if (inputs.isEmpty && opType == OperationType.SHOWDATABASES) { | ||
val resource = AccessResource(DATABASE, null, None) | ||
requests += AccessRequest(resource, ugi, opType, AccessType.USE) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need this logical since we do this in FilteredShowNamespaceExec cc @bowenliang123
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5769 +/- ##
============================================
- Coverage 61.35% 61.35% -0.01%
Complexity 23 23
============================================
Files 607 607
Lines 35917 35921 +4
Branches 4927 4931 +4
============================================
+ Hits 22038 22039 +1
- Misses 11487 11490 +3
Partials 2392 2392 ☔ View full report in Codecov by Sentry. |
Thanks, merged to master |
🔍 Description
Issue References 🔗
This pull request fixes #5768
Describe Your Solution 🔧
Currently all UT have a
ShowNamespace command
and wrapped byObjectFilterPlaceHolder
And
ObjectFilterPlaceHolder
such command will go throughbuildQuery()
, it's noisy when dev to debug and unnecessary, we should just skip it since we have check privilege when executing.Types of changes 🔖
Test Plan 🧪
Behavior Without This Pull Request ⚰️
Behavior With This Pull Request 🎉
Related Unit Tests
Checklists
📝 Author Self Checklist
📝 Committer Pre-Merge Checklist
Be nice. Be informative.