-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KYUUBI #5594][AUTHZ] BuildQuery should respect normal node's input #5595
[KYUUBI #5594][AUTHZ] BuildQuery should respect normal node's input #5595
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5595 +/- ##
============================================
- Coverage 61.67% 61.45% -0.22%
Complexity 23 23
============================================
Files 603 603
Lines 35670 35684 +14
Branches 4869 4872 +3
============================================
- Hits 21999 21930 -69
- Misses 11291 11381 +90
+ Partials 2380 2373 -7
... and 28 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
gentle ping @yaooqinn This is a common issue of authz, pls help check |
How about we add a unit test for this issue? |
Does this issue have a simple solution that we collect leaves for |
Add a UT, the plan is
Without this pr, this query only extract table, miss column privilege
|
Since local branch name changed, can't push to this pr's branch, move to #5627 close this one |
Why are the changes needed?
To close #5594
For case
The logical plan is
When handle
MapInPandas
, we didn't match its input withHiveTableRelation
, cause we miss input table's columns. This pr fix thisHow was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request
With this patch, it can extract the correct privilege object now
Was this patch authored or co-authored using generative AI tooling?