[KYUUBI #5561] Binary distribution artifact ships database schema scripts #5589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cxzl25
reviewed
Oct 31, 2023
build/dist
Outdated
| @@ -270,6 +271,9 @@ echo "Build flags: $@" >> "$DISTDIR/RELEASE" | |||
| # Copy kyuubi server jars | |||
| cp -r "$KYUUBI_HOME"/kyuubi-assembly/target/scala-$SCALA_VERSION/jars/*.jar "$DISTDIR/jars/" | |||
|
|
|||
| # Copy kyuubi metadata sql | |||
| cp -r "$KYUUBI_HOME"/kyuubi-assembly/target/kyuubi-assembly/metastore-sql/* "$DISTDIR/metastore-sql/" | |||
There was a problem hiding this comment.
How about to directly copy kyuubi-server/src/main/resources/sql ?
We should not need maven-assembly-plugin.
There was a problem hiding this comment.
Considering the word "metastore" is famous as an alias of HMS, we'd better not use the same word in Kyuubi terms, I suggest using the generic words to name the folder, for example, "db-schema", "db-scripts"
Codecov Report
@@ Coverage Diff @@
## master #5589 +/- ##
============================================
+ Coverage 61.43% 61.59% +0.15%
Complexity 23 23
============================================
Files 601 603 +2
Lines 34313 35670 +1357
Branches 4499 4869 +370
============================================
+ Hits 21080 21970 +890
- Misses 11098 11308 +210
- Partials 2135 2392 +257 see 23 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pan3793
approved these changes
Nov 1, 2023
cxzl25
approved these changes
Nov 1, 2023
pan3793
changed the title
pan3793
pushed a commit
that referenced
this pull request
Nov 1, 2023
…ipts ### _Why are the changes needed?_ close #5561 ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request ### _Was this patch authored or co-authored using generative AI tooling?_ NO Closes #5589 from lsm1/branch-kyuubi-5561. Closes #5561 831f06a [senmiaoliu] just copy server resource sql 64b90b1 [senmiaoliu] copy metadata sql to dist Authored-by: senmiaoliu <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit c81124b) Signed-off-by: Cheng Pan <[email protected]>
|
After second thought, I decided to rename the folder to |
YesOrNo828
pushed a commit
to YesOrNo828/kyuubi
that referenced
this pull request
Nov 6, 2023
…ma scripts ### _Why are the changes needed?_ close apache#5561 ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request ### _Was this patch authored or co-authored using generative AI tooling?_ NO Closes apache#5589 from lsm1/branch-kyuubi-5561. Closes apache#5561 831f06a [senmiaoliu] just copy server resource sql 64b90b1 [senmiaoliu] copy metadata sql to dist Authored-by: senmiaoliu <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
close #5561
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request
Was this patch authored or co-authored using generative AI tooling?
NO