-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TASK][EASY] Simplify Netty and gRPC dependency management #6294
Comments
Hello, Mr.Pan, I would like to give it a try, but I may not be sure how to clean up these dependencies, so I search some infomation in web, then I learn that I can use The following are the steps I want to take:
If you think there is no problem with my thinking, you can assign this task to me. Thanks. |
your steps should work, but step 2 could be narrowed to root |
Ok, thanks, Mr.Pan. I will try it, please assign this task to me. |
@PorterZhang2021 thanks, assigned |
# 🔍 Description ## Issue References 🔗 This pull request fixes #6294 ## Describe Your Solution 🔧 The netty jars come from `grpc-netty`, `arrow-memory-netty`, use `netty-bom` and `grpc-bom` to simplify the dependency management. Run `./build/dependency.sh --replace` ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6310 from PorterZhang2021/issue-6294. Closes #6294 3270301 [Cheng Pan] simplify netty dependency management cdb435d [PorterZhang2021] [# 6294] Prune unused Netty libraries e0676ed [PorterZhang2021] Finished Prune unused Netty libraries [#6294] Lead-authored-by: PorterZhang2021 <[email protected]> Co-authored-by: Cheng Pan <[email protected]> Signed-off-by: Cheng Pan <[email protected]> (cherry picked from commit 962de72) Signed-off-by: Cheng Pan <[email protected]>
What's the level of this task?
EASY
Code of Conduct
Search before creating
Mentor
Skill requirements
Background and Goals
netty-all
pulls all(maybe?) Netty jars, some are not used by Kyuubi, we should analyze and prune those jars.Implementation steps
Find and remove unused jars(not limited to netty), and make CI happy.
Additional context
Introduction of 2024H1 Kyuubi Code Contribution Program
The text was updated successfully, but these errors were encountered: