Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK][EASY] Simplify Netty and gRPC dependency management #6294

Closed
2 of 3 tasks
pan3793 opened this issue Apr 11, 2024 · 4 comments
Closed
2 of 3 tasks

[TASK][EASY] Simplify Netty and gRPC dependency management #6294

pan3793 opened this issue Apr 11, 2024 · 4 comments
Assignees

Comments

@pan3793
Copy link
Member

pan3793 commented Apr 11, 2024

What's the level of this task?

EASY

Code of Conduct

Search before creating

  • I have searched in the task list and found no similar tasks.

Mentor

  • I have sufficient expertise on this task, and I volunteer to be a mentor of this task to guide contributors through the task.

Skill requirements

  • Familiar with Maven, and Java dependency management.

Background and Goals

netty-all pulls all(maybe?) Netty jars, some are not used by Kyuubi, we should analyze and prune those jars.

Implementation steps

Find and remove unused jars(not limited to netty), and make CI happy.

Additional context

Introduction of 2024H1 Kyuubi Code Contribution Program

@PorterZhang2021
Copy link
Contributor

Hello, Mr.Pan, I would like to give it a try, but I may not be sure how to clean up these dependencies, so I search some infomation in web, then I learn that I can use mvn dependency:analyze to find unused declared dependencies.

The following are the steps I want to take:

  1. Use the mvn depndency:analyze command to find all unused declared dependencies
  2. Go to different pom. XML to clear these dependencies
  3. Re package and verify to see if it can be successfully packaged

If you think there is no problem with my thinking, you can assign this task to me. Thanks.

@pan3793
Copy link
Member Author

pan3793 commented Apr 15, 2024

your steps should work, but step 2 could be narrowed to root pom.xml because Kyuubi manages all dependency version and exclusions in root pom.xml(except for some corner cases). and step 3 could be simplified by dev/dependency.sh

@PorterZhang2021
Copy link
Contributor

your steps should work, but step 2 could be narrowed to root pom.xml because Kyuubi manages all dependency version and exclusions in root pom.xml(except for some corner cases). and step 3 could be simplified by dev/dependency.sh

Ok, thanks, Mr.Pan. I will try it, please assign this task to me.

@pan3793
Copy link
Member Author

pan3793 commented Apr 15, 2024

@PorterZhang2021 thanks, assigned

PorterZhang2021 added a commit to PorterZhang2021/kyuubi that referenced this issue Apr 15, 2024
@pan3793 pan3793 changed the title [TASK][EASY] Prune unused Netty libraries [TASK][EASY] Simplify Netty and gRPC dependency management Apr 17, 2024
pan3793 added a commit that referenced this issue Apr 17, 2024
# 🔍 Description
## Issue References 🔗

This pull request fixes #6294

## Describe Your Solution 🔧

The netty jars come from `grpc-netty`, `arrow-memory-netty`, use `netty-bom` and `grpc-bom` to simplify the dependency management.

Run `./build/dependency.sh --replace`

## Types of changes 🔖

- [ ] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests

---

# Checklist 📝

- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes #6310 from PorterZhang2021/issue-6294.

Closes #6294

3270301 [Cheng Pan] simplify netty dependency management
cdb435d [PorterZhang2021] [# 6294] Prune unused Netty libraries
e0676ed [PorterZhang2021] Finished Prune unused Netty libraries [#6294]

Lead-authored-by: PorterZhang2021 <[email protected]>
Co-authored-by: Cheng Pan <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
(cherry picked from commit 962de72)
Signed-off-by: Cheng Pan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants