Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Support to delete the engine node from ha namespace if failed to connect to engine host:port #5900

Closed
2 of 4 tasks
turboFei opened this issue Dec 21, 2023 · 2 comments
Closed
2 of 4 tasks

[FEATURE] Support to delete the engine node from ha namespace if failed to connect to engine host:port #5900

turboFei opened this issue Dec 21, 2023 · 2 comments
Assignees
@turboFei
Labels
kind:feature Feature request priority:major
Milestone
v1.9.0

Comments

@turboFei
Copy link
Member

turboFei commented Dec 21, 2023 •
edited
Loading

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the feature

Support to delete the engine node from ha namespace if failed to connect to engine host:port

Now if this situation happen(for example, hive client initialization failed because of issue), we have to delete the engine manually.

Motivation

No response

Describe the solution

No response

Additional context

No response

Are you willing to submit PR?

  • Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
  • No. I cannot submit a PR at this time.
@turboFei turboFei mentioned this issue Dec 21, 2023
Closed
18 tasks
@turboFei turboFei self-assigned this Dec 21, 2023
@turboFei turboFei modified the milestones: v1.8.1, v1.9.0 Dec 21, 2023
@pan3793
Copy link
Member

pan3793 commented Dec 22, 2023

The feature is useful in certain cases, but specific to the case you list, should be resolved by #5331

hive client initialization failed because of issue

@turboFei
Copy link
Member Author

The hive client init succeeded when stating the engine, and it connected to old hivemetastore server.

Then we made some migration and shutdown the old hivemetastore server. and then the hive client can be initialized for new connections.

turboFei added a commit that referenced this issue Dec 22, 2023
@turboFei
[KYUUBI #5900] Support to deregister the engine on open failure
f091be0 
# 🔍 Description
## Issue References 🔗

This pull request fixes #5900

## Describe Your Solution 🔧

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

## Types of changes 🔖

- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests

---

# Checklists
## 📝 Author Self Checklist

- [ ] My code follows the [style guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html) of this project
- [ ] I have performed a self-review
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

## 📝 Committer Pre-Merge Checklist

- [ ] Pull request title is okay.
- [ ] No license issues.
- [ ] Milestone correctly set?
- [ ] Test coverage is ok
- [ ] Assignees are selected.
- [ ] Minimum number of approvals
- [ ] No changes are requested

**Be nice. Be informative.**

Closes #5901 from turboFei/delete_engine.

Closes #5900

57bcf1f [Fei Wang] docs
557714e [Fei Wang] enum
bc479e6 [Fei Wang] save
2b2a495 [Fei Wang] refine
f0ace35 [Fei Wang] reset after close client
cf07877 [Fei Wang] re-version
d93dd6a [Fei Wang] refactor

Authored-by: Fei Wang <[email protected]>
Signed-off-by: Fei Wang <[email protected]>
(cherry picked from commit fd397d6)
Signed-off-by: Fei Wang <[email protected]>
turboFei added a commit that referenced this issue Dec 24, 2023
@turboFei
[KYUUBI #5900][FOLLOWUP] Get the engine service node to delete instea…
c290dae 
…d of delete engine space

# 🔍 Description
## Issue References 🔗

Followup for patch #5901
We shall find the engine node first and then delete it instead of deleting the engine space.
This pull request fixes #

## Describe Your Solution 🔧

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

## Types of changes 🔖

- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests

---

# Checklists
## 📝 Author Self Checklist

- [ ] My code follows the [style guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html) of this project
- [ ] I have performed a self-review
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

## 📝 Committer Pre-Merge Checklist

- [ ] Pull request title is okay.
- [ ] No license issues.
- [ ] Milestone correctly set?
- [ ] Test coverage is ok
- [ ] Assignees are selected.
- [ ] Minimum number of approvals
- [ ] No changes are requested

**Be nice. Be informative.**

Closes #5910 from turboFei/deregister_followup.

Closes #5900

f729629 [Fei Wang] ut
6683d9f [Fei Wang] refine
43ad0bf [Fei Wang] save

Authored-by: Fei Wang <[email protected]>
Signed-off-by: Fei Wang <[email protected]>
turboFei added a commit that referenced this issue Dec 24, 2023
@turboFei
[KYUUBI #5900][FOLLOWUP] Get the engine service node to delete instea…
bc479f2 
…d of delete engine space

# 🔍 Description
## Issue References 🔗

Followup for patch #5901
We shall find the engine node first and then delete it instead of deleting the engine space.
This pull request fixes #

## Describe Your Solution 🔧

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

## Types of changes 🔖

- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests

---

# Checklists
## 📝 Author Self Checklist

- [ ] My code follows the [style guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html) of this project
- [ ] I have performed a self-review
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

## 📝 Committer Pre-Merge Checklist

- [ ] Pull request title is okay.
- [ ] No license issues.
- [ ] Milestone correctly set?
- [ ] Test coverage is ok
- [ ] Assignees are selected.
- [ ] Minimum number of approvals
- [ ] No changes are requested

**Be nice. Be informative.**

Closes #5910 from turboFei/deregister_followup.

Closes #5900

f729629 [Fei Wang] ut
6683d9f [Fei Wang] refine
43ad0bf [Fei Wang] save

Authored-by: Fei Wang <[email protected]>
Signed-off-by: Fei Wang <[email protected]>
(cherry picked from commit c290dae)
Signed-off-by: Fei Wang <[email protected]>
zhaohehuhu pushed a commit to zhaohehuhu/incubator-kyuubi that referenced this issue Mar 21, 2024
@turboFei @zhaohehuhu
[KYUUBI apache#5900] Support to deregister the engine on open failure
a2476ad 
# 🔍 Description
## Issue References 🔗

This pull request fixes apache#5900

## Describe Your Solution 🔧

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

## Types of changes 🔖

- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests

---

# Checklists
## 📝 Author Self Checklist

- [ ] My code follows the [style guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html) of this project
- [ ] I have performed a self-review
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

## 📝 Committer Pre-Merge Checklist

- [ ] Pull request title is okay.
- [ ] No license issues.
- [ ] Milestone correctly set?
- [ ] Test coverage is ok
- [ ] Assignees are selected.
- [ ] Minimum number of approvals
- [ ] No changes are requested

**Be nice. Be informative.**

Closes apache#5901 from turboFei/delete_engine.

Closes apache#5900

57bcf1f [Fei Wang] docs
557714e [Fei Wang] enum
bc479e6 [Fei Wang] save
2b2a495 [Fei Wang] refine
f0ace35 [Fei Wang] reset after close client
cf07877 [Fei Wang] re-version
d93dd6a [Fei Wang] refactor

Authored-by: Fei Wang <[email protected]>
Signed-off-by: Fei Wang <[email protected]>
zhaohehuhu pushed a commit to zhaohehuhu/incubator-kyuubi that referenced this issue Mar 21, 2024
@turboFei @zhaohehuhu
[KYUUBI apache#5900][FOLLOWUP] Get the engine service node to delete …
329cd51 
…instead of delete engine space

# 🔍 Description
## Issue References 🔗

Followup for patch apache#5901
We shall find the engine node first and then delete it instead of deleting the engine space.
This pull request fixes #

## Describe Your Solution 🔧

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

## Types of changes 🔖

- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests

---

# Checklists
## 📝 Author Self Checklist

- [ ] My code follows the [style guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html) of this project
- [ ] I have performed a self-review
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

## 📝 Committer Pre-Merge Checklist

- [ ] Pull request title is okay.
- [ ] No license issues.
- [ ] Milestone correctly set?
- [ ] Test coverage is ok
- [ ] Assignees are selected.
- [ ] Minimum number of approvals
- [ ] No changes are requested

**Be nice. Be informative.**

Closes apache#5910 from turboFei/deregister_followup.

Closes apache#5900

f729629 [Fei Wang] ut
6683d9f [Fei Wang] refine
43ad0bf [Fei Wang] save

Authored-by: Fei Wang <[email protected]>
Signed-off-by: Fei Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turboFei turboFei

Labels
kind:feature Feature request priority:major
Projects
None yet
Milestone
v1.9.0
Development

Successfully merging a pull request may close this issue.

[KYUUBI #5900] Support to deregister the engine on open failure turboFei/kyuubi
2 participants
@turboFei @pan3793