From 65e1f593ef24c5f7be8d5fc5cc6170d9c7540035 Mon Sep 17 00:00:00 2001
From: dnskr <dnskrv88@gmail.com>
Date: Sun, 15 Jan 2023 01:38:32 +0100
Subject: [PATCH] [K8S][HELM] Address some PR comments

---
 charts/kyuubi/templates/_helpers.tpl           |  2 +-
 charts/kyuubi/templates/kyuubi-deployment.yaml |  4 ++--
 charts/kyuubi/values.yaml                      | 18 +++++++++---------
 3 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/charts/kyuubi/templates/_helpers.tpl b/charts/kyuubi/templates/_helpers.tpl
index 0479f9efe4d..04a3d9d75ce 100644
--- a/charts/kyuubi/templates/_helpers.tpl
+++ b/charts/kyuubi/templates/_helpers.tpl
@@ -16,7 +16,7 @@
 */}}
 
 {{/*
-A comma separated string of enabled frontend protocols, e.g. "MYSQL,REST,THRIFT_BINARY".
+A comma separated string of enabled frontend protocols, e.g. "REST,THRIFT_BINARY".
 For details, see 'kyuubi.frontend.protocols': https://kyuubi.readthedocs.io/en/master/deployment/settings.html#frontend
 */}}
 {{- define "kyuubi.frontend.protocols" -}}
diff --git a/charts/kyuubi/templates/kyuubi-deployment.yaml b/charts/kyuubi/templates/kyuubi-deployment.yaml
index d409eb1aca6..73a4fa89805 100644
--- a/charts/kyuubi/templates/kyuubi-deployment.yaml
+++ b/charts/kyuubi/templates/kyuubi-deployment.yaml
@@ -66,7 +66,7 @@ spec:
           {{- if .Values.probe.liveness.enabled }}
           livenessProbe:
             exec:
-              command: ["/bin/sh", "-c", "bin/kyuubi status"]
+              command: ["/bin/bash", "-c", "bin/kyuubi status"]
             initialDelaySeconds: {{ .Values.probe.liveness.initialDelaySeconds }}
             periodSeconds: {{ .Values.probe.liveness.periodSeconds }}
             timeoutSeconds: {{ .Values.probe.liveness.timeoutSeconds }}
@@ -76,7 +76,7 @@ spec:
           {{- if .Values.probe.readiness.enabled }}
           readinessProbe:
             exec:
-              command: [ "/bin/sh", "-c", "$KYUUBI_HOME/bin/kyuubi status" ]
+              command: ["/bin/bash", "-c", "$KYUUBI_HOME/bin/kyuubi status"]
             initialDelaySeconds: {{ .Values.probe.readiness.initialDelaySeconds }}
             periodSeconds: {{ .Values.probe.readiness.periodSeconds }}
             timeoutSeconds: {{ .Values.probe.readiness.timeoutSeconds }}
diff --git a/charts/kyuubi/values.yaml b/charts/kyuubi/values.yaml
index 7be0ce75896..f2d0a521753 100644
--- a/charts/kyuubi/values.yaml
+++ b/charts/kyuubi/values.yaml
@@ -111,17 +111,17 @@ frontend:
 
 kyuubiConfDir: /opt/kyuubi/conf
 kyuubiConf:
-    # The value (templated string) is used for kyuubi-env.sh file
-    # See https://kyuubi.apache.org/docs/latest/deployment/settings.html#environments for more details
-    kyuubiEnv: ~
+  # The value (templated string) is used for kyuubi-env.sh file
+  # See https://kyuubi.apache.org/docs/latest/deployment/settings.html#environments for more details
+  kyuubiEnv: ~
 
-    # The value (templated string) is used for kyuubi-defaults.conf file
-    # See https://kyuubi.apache.org/docs/latest/deployment/settings.html#kyuubi-configurations for more details
-    kyuubiDefaults: ~
+  # The value (templated string) is used for kyuubi-defaults.conf file
+  # See https://kyuubi.apache.org/docs/latest/deployment/settings.html#kyuubi-configurations for more details
+  kyuubiDefaults: ~
 
-    # The value (templated string) is used for log4j2.xml file
-    # See https://kyuubi.apache.org/docs/latest/deployment/settings.html#logging for more details
-    log4j2: ~
+  # The value (templated string) is used for log4j2.xml file
+  # See https://kyuubi.apache.org/docs/latest/deployment/settings.html#logging for more details
+  log4j2: ~
 
 # Environment variables (templated)
 env: []