-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(stream): change XREADGROUP response for empty read response #2569
Conversation
@jonathanc-n Should we change existing tests or add extra tests for this case if they don't exist? |
@torwig changes in this particular pr are negligible so probably doesn't need a test, but for the other half of the issue I believe there should be a test. |
@jonathanc-n How to be sure that bug was fixed? Exactly, write a test :) There is a classic flow for fixing a bug:
|
I see, thank you for letting me know! :) |
@torwig The test is added |
@torwig I made some changes to the stream, hopefully it passes all the checks now |
@PragmaTwice Do you know why this might be failing? I am not too sure myself |
It keeps failing even after multiple retries. I'll look into it soon. |
Quality Gate passedIssues Measures |
Co-authored-by: Twice <[email protected]>
references #2568
Changed XReadGroup response for empty responses to match redis behaviour.