Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve][Manager] refactor code for building and submitting flink job #10353

Closed
2 tasks done
Tracked by #9779
aloyszhang opened this issue Jun 5, 2024 · 0 comments · Fixed by #10354
Closed
2 tasks done
Tracked by #9779

[Improve][Manager] refactor code for building and submitting flink job #10353

aloyszhang opened this issue Jun 5, 2024 · 0 comments · Fixed by #10354
Assignees
@aloyszhang
Labels
type/improve
Milestone
1.13.0

Comments

@aloyszhang
Copy link
Contributor

Description

Currently

  1. the building and submission of the Flink job have duplicated code in StartupStreamListener and StartupSortListener
  2. in StartupSortListener the process for stream exception is not consistent
  • if there is no valid sink configuration for a stream, this stream is skipped, and continue processing the following ones
  • if no dataflow for a stream, the whole process will quit directly without processing the following streams
  • if an exception occurs when submitted to Flink, the whole process will quit

we should simplify the duplicated codes and unify the processing for exceptions for stream in StartupSortListener.

InLong Component

InLong Manager

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aloyszhang aloyszhang

Labels
type/improve
Projects
None yet
Milestone
1.13.0
Development

Successfully merging a pull request may close this issue.

[INLONG-10353][Manager] Refactor code for building and submitting flink job aloyszhang/inlong
1 participant
@aloyszhang