This repository has been archived by the owner on Jun 3, 2021. It is now read-only.
[jsfm] Enhance the multi-instance isolation (sandbox) #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upgrade weex-vue-framework to 2.5.11-weex.1 upgrade weex-rax-framework to 0.4.20
Use "createInstanceContext" instead of "createInstance". JS Framework only needs to prepare the instance context and no longer execute the js code. The js code will be executed by native. This *sandbox* feature requires native to cooperate to achieve.
Generated by 🚫 dangerJS |
|
@yacheng @acton393 @yuhun-alibaba Please take a review. |
Hanks10100
force-pushed
the
jsfm-feature-sandbox
branch
2 times, most recently
from
0074792 to
9807474
Compare
Hanks10100
force-pushed
the
jsfm-feature-sandbox
branch
from
0ea1a81 to
3d589d4
Compare
acton393
approved these changes
Dec 29, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the discussion in the mailing list (Use multi-context for Weex page), the current isolation strategy is vulnerable, distinguish the "Global Context" and the "Instance Context" is a more reasonable solution.
In practice, the logic of instance management and code execution will be moved from js framework to native render engines.
This PR implement a new
createInstanceContextAPI instead of the formercreateInstanceto create the instance context for each page. Refer to this PR to see the modification in the Vue.js framework. Rax doesn't support it yet.As for native render engines, they should also call
createInstanceContextinstead ofcreateInstance, and parse the bundle type of the code (Vue or Rax) and then send it to js framework.