[COREML]multiple output support, reshape, split ops added #6296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandron
reviewed
Aug 18, 2020
| outname = outnames if isinstance(outnames, _base.string_types) else outnames[0] | ||
| etab.set_expr(outname, outs, force_override=True) | ||
| else: | ||
| assert len(outnames) == len(outs) |
There was a problem hiding this comment.
minor suggestion: it would be helpful to have a message for the assertion here.
python/tvm/relay/frontend/coreml.py
Outdated
| @@ -474,7 +484,7 @@ def coreml_op_to_relay(op, inname, outname, etab): | |||
| inname : str or list of str | |||
| Name of the input Relay expression. | |||
|
|
|||
| outname : str | |||
| outnames : str | |||
There was a problem hiding this comment.
Is this also expected to be str or list of str, based on usage on line 509?
FrozenGene
approved these changes
Aug 19, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
* [COREML]multiple output support, reshape, split ops added * Review comments addressed
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
* [COREML]multiple output support, reshape, split ops added * Review comments addressed
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
* [COREML]multiple output support, reshape, split ops added * Review comments addressed
electriclilies
pushed a commit
to electriclilies/tvm
that referenced
this pull request
Aug 26, 2020
* [COREML]multiple output support, reshape, split ops added * Review comments addressed
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Sep 2, 2020
* [COREML]multiple output support, reshape, split ops added * Review comments addressed
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 3, 2020
* [COREML]multiple output support, reshape, split ops added * Review comments addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reshape, split support added in coreml
@FrozenGene @masahi please help me to review this PR. TIA