[Relay][Dyn] Dynamic full operator #6260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrookhart
reviewed
Aug 12, 2020
Comment on lines
+204
to
+206
| register_shape_func("zeros", False, full_shape_func) | ||
| register_shape_func("zeros_like", False, elemwise_shape_func) | ||
| register_shape_func("ones", True, no_data_full_shape_func) | ||
| register_shape_func("ones", False, full_shape_func) |
There was a problem hiding this comment.
:/ Is this a rebase error?
There was a problem hiding this comment.
No, I was going through my code and I forgot to change this for the zeros and ones PR -- for the static shape ones and zeros, it is not data dependent since the shape of the input is in attributes, and uses the normal full_shape_func. It passes the tests for static ones and zeros..
There was a problem hiding this comment.
Perhaps I should just remove the shape func registration for the static ops, it seems like this change didn't affect any behavior.
mbrookhart
approved these changes
Aug 12, 2020
zhiics
approved these changes
Aug 13, 2020
|
Thanks @electriclilies @mbrookhart |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
* moved full from other branch * fixed some typos * fix lint * add final newline * fix int64 test
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
* moved full from other branch * fixed some typos * fix lint * add final newline * fix int64 test
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
* moved full from other branch * fixed some typos * fix lint * add final newline * fix int64 test
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Sep 2, 2020
* moved full from other branch * fixed some typos * fix lint * add final newline * fix int64 test
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 3, 2020
* moved full from other branch * fixed some typos * fix lint * add final newline * fix int64 test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dynamic version of the full operator
@mbrookhart @zhiics Let me know if you have any suggestions