Fix division range estimation error in simplifier #6244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Division a/b assumes maximum values when b is close to 0. Account for that when estimating the range for a/b when 0 belongs to the estimated range for b. Assume that a division by zero cannot happen in a valid program, so in such cases treat the range for b as a union [b.min_value, -1] u [1, b.max_value]
tqchen
approved these changes
Aug 11, 2020
|
Thanks @kparzysz-quic ! |
wjliu1998
pushed a commit
to wjliu1998/incubator-tvm
that referenced
this pull request
Aug 13, 2020
Division a/b assumes maximum values when b is close to 0. Account for that when estimating the range for a/b when 0 belongs to the estimated range for b. Assume that a division by zero cannot happen in a valid program, so in such cases treat the range for b as a union [b.min_value, -1] u [1, b.max_value]
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
Division a/b assumes maximum values when b is close to 0. Account for that when estimating the range for a/b when 0 belongs to the estimated range for b. Assume that a division by zero cannot happen in a valid program, so in such cases treat the range for b as a union [b.min_value, -1] u [1, b.max_value]
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
Division a/b assumes maximum values when b is close to 0. Account for that when estimating the range for a/b when 0 belongs to the estimated range for b. Assume that a division by zero cannot happen in a valid program, so in such cases treat the range for b as a union [b.min_value, -1] u [1, b.max_value]
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
Division a/b assumes maximum values when b is close to 0. Account for that when estimating the range for a/b when 0 belongs to the estimated range for b. Assume that a division by zero cannot happen in a valid program, so in such cases treat the range for b as a union [b.min_value, -1] u [1, b.max_value]
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Sep 2, 2020
Division a/b assumes maximum values when b is close to 0. Account for that when estimating the range for a/b when 0 belongs to the estimated range for b. Assume that a division by zero cannot happen in a valid program, so in such cases treat the range for b as a union [b.min_value, -1] u [1, b.max_value]
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 3, 2020
Division a/b assumes maximum values when b is close to 0. Account for that when estimating the range for a/b when 0 belongs to the estimated range for b. Assume that a division by zero cannot happen in a valid program, so in such cases treat the range for b as a union [b.min_value, -1] u [1, b.max_value]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Division
a/bassumes maximum values whenbis close to0. Account for that when estimating the range fora/bwhen0belongs to the estimated range forb.Assume that a division by zero cannot happen in a valid program, so in such cases treat the range for
bas a union[b.min_value, -1] u [1, b.max_value].