[Relay][Dynamic] Add Dynamic Resize Op #6198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -239,6 +245,7 @@ def affine_grid(data, target_shape=None): | |||
| """ | |||
| return _make.affine_grid(data, target_shape) | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Remove extra white space
There was a problem hiding this comment.
I ran Yapf on it, which inserted this line. Looking up Pep8 to be sure, we need two lines between top level functions in a module: https://www.python.org/dev/peps/pep-0008/#blank-lines
| .add_argument("data", "Tensor", "The input tensor.") | ||
| .add_argument("size", "Tensor", "The output size tensor.") | ||
| .set_support_level(5) | ||
| .add_type_rel("DynResize", ResizeRel) |
There was a problem hiding this comment.
Did you decide to leave out the FInferCorrectLayout pass?
There was a problem hiding this comment.
No, it isn't present in the static version either.
|
cc @yongwww |
mbrookhart
force-pushed
the
mbrookhart/dynamic_resize
branch
from
daf54b3 to
d56b966
Compare
|
Cool. We do need this to support TF RCNN models with dynamic image size. I'll update tf frontend after this is merged. |
added 9 commits
August 6, 2020 08:50
add resize to dynamic_to_static pass
mbrookhart
force-pushed
the
mbrookhart/dynamic_resize
branch
from
1a4896c to
1cea338
Compare
|
Thanks @mbrookhart @electriclilies @zhiics |
wjliu1998
pushed a commit
to wjliu1998/incubator-tvm
that referenced
this pull request
Aug 13, 2020
* WIP * optionally remove output shape inference from topi * fix resize * add resize to dynamic_to_static pass add resize to dynamic_to_static pass * fix clang-format * fix bad rebase * add argument to dynamic resize doc string * fix i386 test * fix lint
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
* WIP * optionally remove output shape inference from topi * fix resize * add resize to dynamic_to_static pass add resize to dynamic_to_static pass * fix clang-format * fix bad rebase * add argument to dynamic resize doc string * fix i386 test * fix lint
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
* WIP * optionally remove output shape inference from topi * fix resize * add resize to dynamic_to_static pass add resize to dynamic_to_static pass * fix clang-format * fix bad rebase * add argument to dynamic resize doc string * fix i386 test * fix lint
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
* WIP * optionally remove output shape inference from topi * fix resize * add resize to dynamic_to_static pass add resize to dynamic_to_static pass * fix clang-format * fix bad rebase * add argument to dynamic resize doc string * fix i386 test * fix lint
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Sep 2, 2020
* WIP * optionally remove output shape inference from topi * fix resize * add resize to dynamic_to_static pass add resize to dynamic_to_static pass * fix clang-format * fix bad rebase * add argument to dynamic resize doc string * fix i386 test * fix lint
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 3, 2020
* WIP * optionally remove output shape inference from topi * fix resize * add resize to dynamic_to_static pass add resize to dynamic_to_static pass * fix clang-format * fix bad rebase * add argument to dynamic resize doc string * fix i386 test * fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @icemelon9 for some help debugging a unit test.
cc @zhiics @electriclilies