Gather operation with indices as tensor expr in TFLite frontend #6168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siju-samuel
reviewed
Aug 11, 2020
Added handling of indices as tensor expr to gather operation, unit tests amended Code cheking out of boundary error refactored in more "pythonic" way. Fixed bug in negative axis value normalisation
d-smirnov
force-pushed
the
gather_indices_expr
branch
from
c1df2be to
2bd509f
Compare
|
Thanks @siju-samuel @d-smirnov This is merged! |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
…he#6168) * gather with indices as tensor expr Added handling of indices as tensor expr to gather operation, unit tests amended Code cheking out of boundary error refactored in more "pythonic" way. Fixed bug in negative axis value normalisation * replaced with get_tensor_expr
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
…he#6168) * gather with indices as tensor expr Added handling of indices as tensor expr to gather operation, unit tests amended Code cheking out of boundary error refactored in more "pythonic" way. Fixed bug in negative axis value normalisation * replaced with get_tensor_expr
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
…he#6168) * gather with indices as tensor expr Added handling of indices as tensor expr to gather operation, unit tests amended Code cheking out of boundary error refactored in more "pythonic" way. Fixed bug in negative axis value normalisation * replaced with get_tensor_expr
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Sep 2, 2020
…he#6168) * gather with indices as tensor expr Added handling of indices as tensor expr to gather operation, unit tests amended Code cheking out of boundary error refactored in more "pythonic" way. Fixed bug in negative axis value normalisation * replaced with get_tensor_expr
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 3, 2020
…he#6168) * gather with indices as tensor expr Added handling of indices as tensor expr to gather operation, unit tests amended Code cheking out of boundary error refactored in more "pythonic" way. Fixed bug in negative axis value normalisation * replaced with get_tensor_expr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds handling of indices as tensor expr to "gather" operation in TFLite frontend. Also the code checking out of boundary error refactored in slightly more "pythonic" way. Fixed bug in negative axis value normalisation