[Relay][VM] Allow to config allocator type and refactor vm code structure #6105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jroesch
reviewed
Jul 22, 2020
jroesch
approved these changes
Jul 22, 2020
zhiics
reviewed
Jul 22, 2020
|
@icemelon9 it looks like something is wrong with CI can you try retriggering? |
zhiics
approved these changes
Jul 23, 2020
|
Thanks @icemelon9 @jroesch |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
…ture (apache#6105) * [Relay][VM] Allow to config allocator type and refactor vm code structure * fix doc * fix * update * trigger ci * trigger ci * trigger ci * trigger ci * fix doc warning
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
…ture (apache#6105) * [Relay][VM] Allow to config allocator type and refactor vm code structure * fix doc * fix * update * trigger ci * trigger ci * trigger ci * trigger ci * fix doc warning
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
…ture (apache#6105) * [Relay][VM] Allow to config allocator type and refactor vm code structure * fix doc * fix * update * trigger ci * trigger ci * trigger ci * trigger ci * fix doc warning
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Sep 2, 2020
…ture (apache#6105) * [Relay][VM] Allow to config allocator type and refactor vm code structure * fix doc * fix * update * trigger ci * trigger ci * trigger ci * trigger ci * fix doc warning
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 3, 2020
…ture (apache#6105) * [Relay][VM] Allow to config allocator type and refactor vm code structure * fix doc * fix * update * trigger ci * trigger ci * trigger ci * trigger ci * fix doc warning
| self._init = self.module["init"] | ||
| self._invoke = self.module["invoke"] | ||
| self._set_input = self.module["set_input"] | ||
| self._setup_ctx(ctx, memory_cfg) |
There was a problem hiding this comment.
@icemelon Hi Haichen, I'm curious that why we do _setup_ctx (now is _setup_device separately? Is there any specific reason not to setup devices in vm_load_executable?
Line 374 in d62a364
I think we can prepare the device arguments in ahead and convey them to vm_load_executable 🤔 ?
cc @YuchenJin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly made two changes: