Change the meaning of conv3d_transpose output_padding to match conv{1,2}d_transpose #6065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abergeron
changed the title
abergeron
changed the title
|
It seems the mac build actually succeeded but there was a fluke failure. Should I push an empty commit to restart or is it possible to restart manually? |
|
Something is weird with the mac build, I'll try an empty commit. |
|
It seems the master is broken, because some rust test is failing and I didn't touch any of the rust code. It also seems that the macOS build is flaky because it passed with the first empty commit and failed with the second. I will hold off on the re-triggers of the CI until I hear the problem has been fixed. |
|
The CI problem appears to be fixed, so I'm trying again. |
|
@vinx13 This is ready for review/merging. |
vinx13
requested changes
Aug 2, 2020
abergeron
force-pushed
the
fix_conv3d_transpose_out_pad
branch
from
45a727c to
b470b9a
Compare
|
I've rebased this on top of the topi refactor. |
vinx13
approved these changes
Aug 5, 2020
wjliu1998
pushed a commit
to wjliu1998/incubator-tvm
that referenced
this pull request
Aug 13, 2020
…,2}d_transpose (apache#6065) * Change the meaning of output_padding to correspond to conv{1,2}d_transpose * Fix long lines * Fix the relay test * Add missing doc. * fix size ordering problem
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
…,2}d_transpose (apache#6065) * Change the meaning of output_padding to correspond to conv{1,2}d_transpose * Fix long lines * Fix the relay test * Add missing doc. * fix size ordering problem
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
…,2}d_transpose (apache#6065) * Change the meaning of output_padding to correspond to conv{1,2}d_transpose * Fix long lines * Fix the relay test * Add missing doc. * fix size ordering problem
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
…,2}d_transpose (apache#6065) * Change the meaning of output_padding to correspond to conv{1,2}d_transpose * Fix long lines * Fix the relay test * Add missing doc. * fix size ordering problem
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Sep 2, 2020
…,2}d_transpose (apache#6065) * Change the meaning of output_padding to correspond to conv{1,2}d_transpose * Fix long lines * Fix the relay test * Add missing doc. * fix size ordering problem
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 3, 2020
…,2}d_transpose (apache#6065) * Change the meaning of output_padding to correspond to conv{1,2}d_transpose * Fix long lines * Fix the relay test * Add missing doc. * fix size ordering problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the follow-up to #5758 for conv3d.
All tests pass and work, but I noticed that there aren't any non-symmetrical shapes in the conv3d tests and adding such shapes gives a failing test, because the ref and output will have different shapes like (1, 16, 73, 72, 74) and (1, 16, 74, 73, 72). This is why one of the tests is commented out.
Ping: @vinx13 @siju-samuel