[RUNTIME][CRT] init TVMPackedFunc's name #6044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
areusch
approved these changes
Jul 13, 2020
liangfu
requested changes
Jul 14, 2020
There was a problem hiding this comment.
Thanks for bringing the fix @windclarion . However, I think strncpy should be replace by snprintf to avoid unsafe behavior in MISRA-C runtime, otherwise look good.
windclarion
force-pushed
the
init_crt_func_name
branch
3 times, most recently
from
8521dfb to
1e23fcc
Compare
liangfu
reviewed
Jul 14, 2020
windclarion
force-pushed
the
init_crt_func_name
branch
from
52f4773 to
052016c
Compare
|
just rebase to retrigger, I can't understand fail message |
|
This is a known flaky error, please retrigger again |
or else src/runtime/crt/graph_runtime/graph_runtime.c TVMGraphRuntime_Run Line 639 will show messy code. Signed-off-by: windclarion <[email protected]>
windclarion
force-pushed
the
init_crt_func_name
branch
from
052016c to
7429887
Compare
liangfu
approved these changes
Jul 16, 2020
|
Thanks @windclarion for contributing. Thanks @tqchen for reviewing. This is now merged. |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
or else src/runtime/crt/graph_runtime/graph_runtime.c TVMGraphRuntime_Run Line 639 will show messy code. Signed-off-by: windclarion <[email protected]>
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
or else src/runtime/crt/graph_runtime/graph_runtime.c TVMGraphRuntime_Run Line 639 will show messy code. Signed-off-by: windclarion <[email protected]>
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Sep 2, 2020
or else src/runtime/crt/graph_runtime/graph_runtime.c TVMGraphRuntime_Run Line 639 will show messy code. Signed-off-by: windclarion <[email protected]>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 3, 2020
or else src/runtime/crt/graph_runtime/graph_runtime.c TVMGraphRuntime_Run Line 639 will show messy code. Signed-off-by: windclarion <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
or else src/runtime/crt/graph_runtime/graph_runtime.c TVMGraphRuntime_Run
Line 639 will show messy character.