[LLVM] Remove redundant function CreateBufferVecPtr #5982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The functions CreateBufferPtr and CreateBufferVecPtr do the exact same thing, so there is no need for both of them to exist. The latter is only used in place, which further suggests that the distinction is unnecessary.
tqchen
approved these changes
Jul 2, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jul 14, 2020
The functions CreateBufferPtr and CreateBufferVecPtr do the exact same thing, so there is no need for both of them to exist. The latter is only used in place, which further suggests that the distinction is unnecessary.
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jul 14, 2020
The functions CreateBufferPtr and CreateBufferVecPtr do the exact same thing, so there is no need for both of them to exist. The latter is only used in place, which further suggests that the distinction is unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions
CreateBufferPtrandCreateBufferVecPtrdo the exact same thing, so there is no need for both of them to exist. Thelatter is only used in place, which further suggests that the distinction is unnecessary.