[RELAY][GRAD] handle Tuple/TupleGetItem in first order gradient #5946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@junrushao1994 @MarisaKirisame @tqchen for the friends of gradients... I have a third thing (fixing an efficiency issue I found), but it also is in |
tqchen
changed the title
|
also cc @yzhliu @icemelon9 |
MarisaKirisame
approved these changes
Jun 29, 2020
src/relay/transforms/gradient.cc
Outdated
| } | ||
| return Tuple(res); | ||
| } else { | ||
| LOG(FATAL) << "unsupported type to zero: " << tt; |
There was a problem hiding this comment.
Suggested change
| LOG(FATAL) << "unsupported type to zero: " << tt; | |
| LOG(FATAL) << "unsupported type to ones: " << tt; |
There was a problem hiding this comment.
This goes away with the unification...
src/relay/transforms/gradient.cc
Outdated
| @@ -106,14 +106,67 @@ struct ADValueNode { | |||
| } | |||
| }; | |||
|
|
|||
| Expr MultiZerosType(const Type& t) { | |||
There was a problem hiding this comment.
can you unify MultiZeros with MultiOnes?
There was a problem hiding this comment.
I just pushed that. Thank you for the suggestion.
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 30, 2020
…he#5946) * handle Tuple/TupleGetItem in first order gradient * Unify MultiOnes/MultiZeros.
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jul 2, 2020
…he#5946) * handle Tuple/TupleGetItem in first order gradient * Unify MultiOnes/MultiZeros.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tuple support for first order gradients.
We may have tuples passed to or returned from functions and at this stage, they aren't inlined (because we want to compute gradients based on that granularity), limiting the possibility to eliminate Tuple/GetTupleItem.
Examples of ops with tupels include dropout and concatenate.