Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Add cuda 11 to contrib.nvcc.find_libdevice_path() #5902

Merged
merged 1 commit into from
Jun 28, 2020
Merged

[BUGFIX] Add cuda 11 to contrib.nvcc.find_libdevice_path() #5902

merged 1 commit into from
Jun 28, 2020

Conversation

ymwangg
Copy link
Contributor

@ymwangg ymwangg commented Jun 23, 2020

The following code will fail when using CUDA 11 and causes test cases of nvptx target to fail. This PR fixed this issue.

tvm.contrib.nvcc.find_libdevice_path('7.0')
ValueError: Traceback (most recent call last):
  [bt] (1) /home/ubuntu/src/tvm/build/libtvm.so(TVMFuncCall+0x65) [0x7fc26a6064b5]
  [bt] (0) /home/ubuntu/src/tvm/build/libtvm.so(+0xe10dbb) [0x7fc26a602dbb]
  File "/home/ubuntu/src/tvm/python/tvm/_ffi/_ctypes/packed_func.py", line 78, in cfun
    rv = local_pyfunc(*pyargs)
  File "/home/ubuntu/src/tvm/python/tvm/contrib/nvcc.py", line 182, in find_libdevice_path
    ver = int(fn.split(".")[-3].split("_")[-1])
ValueError: invalid literal for int() with base 10: 'libdevice'

junrushao
junrushao approved these changes Jun 23, 2020
View reviewed changes
Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tqchen tqchen merged commit 79f3db6 into apache:master Jun 28, 2020
@tqchen
Copy link
Member

tqchen commented Jun 28, 2020

Thankw @ymwangg , @junrushao1994 !

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 30, 2020
@ymwangg
[BUGFIX] Add cuda 11 to contrib.nvcc.find_libdevice_path() (apache#5902)
df2d87b
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Jul 2, 2020
@ymwangg @zhiics
[BUGFIX] Add cuda 11 to contrib.nvcc.find_libdevice_path() (apache#5902)
4eb0783
@ymwangg ymwangg deleted the ymwang-dev branch July 13, 2020 22:43
@ZihengJiang ZihengJiang mentioned this pull request Sep 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junrushao junrushao junrushao approved these changes

@tqchen tqchen tqchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ymwangg @tqchen @junrushao