Add Binary Intrinsic ops to TIR Ops in C++ #5900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junrushao
approved these changes
Jun 23, 2020
tqchen
approved these changes
Jun 23, 2020
|
Thanks @mbrookhart @junrushao1994 ! |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 30, 2020
* Add Binary Intrinsic ops to TIR Ops in C++ * clang-format
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jul 2, 2020
* Add Binary Intrinsic ops to TIR Ops in C++ * clang-format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tqchen
These ops are already registered and tested through python, this simply adds them to the C++ API. I don't see tests for the existing instrinsic unary ops outside of python, do we test this C++ API?
https://github.com/apache/incubator-tvm/blob/90b08f5e4ef5a40e1efb9a9ba2882df87b0a9391/tests/python/unittest/test_tir_intrin.py#L92-L134