Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install.rst #5858

Merged
merged 2 commits into from
Jun 25, 2020
Merged

Update install.rst #5858

merged 2 commits into from
Jun 25, 2020

Conversation

badenh
Copy link
Contributor

@badenh badenh commented Jun 20, 2020

minor cleanups/corrections

Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.

minor cleanups/corrections
Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes, LGTM

@tmoreau89
Copy link
Contributor

Looks like one of the edits on the section titles is breaking a link in the RST. Can you fix line 23 of the file to add the missing "VTA "? Thanks

@tmoreau89
Copy link
Contributor

Until then we cannot merge the fixes.

@tmoreau89
Copy link
Contributor

@badenh Please let us know if you can fix the install.rst to pass the CI tests

Fixed broken link
@badenh
Copy link
Contributor Author

badenh commented Jun 25, 2020

Yes, fixed the missing item now

@tmoreau89 tmoreau89 merged commit 2a03d24 into apache:master Jun 25, 2020
@tmoreau89
Copy link
Contributor

thank you @badenh your changes have been merged

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 30, 2020
* Update install.rst

minor cleanups/corrections

* Update install.rst

Fixed broken link
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Jul 2, 2020
* Update install.rst

minor cleanups/corrections

* Update install.rst

Fixed broken link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants