[Arith] Inequalities solver #5618
Conversation
|
@tqchen @sergei-grechanik @MarisaKirisame @eric-haibin-lin @ArmageddonKnight It's ready for review. |
|
Also cc @xqdan @junrushao1994 if you have time review. |
Co-authored-by: Sergei Grechanik <[email protected]>
python/tvm/testing.py
Outdated
|
|
||
| rels = constraints_trans.dst.relations | ||
| if len(rels) == 1 and tvm.ir.structural_equal(rels[0], False): | ||
| # not solvable, skip |
There was a problem hiding this comment.
I think it should be checked here that the original constraints are also unsolvable.
There was a problem hiding this comment.
yes.. but how can I detect the contradiction in the original constraints without running the solver?
There was a problem hiding this comment.
You can check that the original constraints are false for all values of the variables. I would remove this check completely, I think _check_forward should do what is needed automatically or with some minor changes.
There was a problem hiding this comment.
@yzhliu : Thanks for the PR! Great work 👍
Please find some high level comments and some queries. Thanks!
include/tvm/arith/int_solver.h
Outdated
| * \param r The range | ||
| * \return constructed bounds. | ||
| */ | ||
| static IntGrpBounds range(const Range& r); |
There was a problem hiding this comment.
Maybe range --> CreateIntGrpBounds (Or something like that, as we are creating Bounds from Range)?
There was a problem hiding this comment.
I'm ok with either way. This is following https://github.com/apache/incubator-tvm/blob/master/src/arith/int_set.cc#L600
There was a problem hiding this comment.
Thanks! I see now. I am also okay if it is general convention:)
@tqchen : Do you have any thoughts on the comment ?
|
@sergei-grechanik @ANSHUMAN87 @tqchen @MarisaKirisame Please take a look again. |
| // Note that we use the 0-th expression because they are ordered by complexity, | ||
| // so it must be the simplest one. | ||
| Range best_range(bnd->equal[0], analyzer.Simplify(bnd->equal[0] + 1, 3)); | ||
| res_ranges.Set(var, best_range); |
There was a problem hiding this comment.
nit: res_ranges.Set & vranges.Set can be taken to common place below if...else... block.
There was a problem hiding this comment.
in the else branch, they are not set unless best_range is defined.
include/tvm/arith/int_solver.h
Outdated
| * coef * var <= upper | ||
| * \sa IntGrpBounds | ||
| */ | ||
| class IntGrpBoundsNode : public Object { |
include/tvm/arith/int_solver.h
Outdated
| * \param r The range | ||
| * \return constructed bounds. | ||
| */ | ||
| static IntGrpBounds range(const Range& r); |
|
|
||
| @staticmethod | ||
| def make_by_range(rng): | ||
| """Construct a IntGroupedBounds by Range. |
|
@tqchen @ANSHUMAN87 Please take a look again. |
|
@tqchen kindly ping |
tqchen
added
status: accepted
and removed
status: need review
status: need update
This is the LinearInequalitySolver mentioned in https://discuss.tvm.ai/t/rfc-bring-in-tensor-expression-autodiff