[RUNTIME] Improve PackedFunc robustness #5517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tqchen
commented
May 5, 2020
tqchen
commented
- Add static assert to warn about unsupported type deduction.
- Always inline template expansions for PackedFunc calls.
- Add static assert to warn about unsupported type deduction. - Always inline template expansions for PackedFunc calls.
zhiics
approved these changes
May 6, 2020
siju-samuel
reviewed
May 6, 2020
|
THanks @siju-samuel @zhiics |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 9, 2020
* [RUNTIME] Improve PackedFunc robustness - Add static assert to warn about unsupported type deduction. - Always inline template expansions for PackedFunc calls. * Fix style issue
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 18, 2020
* [RUNTIME] Improve PackedFunc robustness - Add static assert to warn about unsupported type deduction. - Always inline template expansions for PackedFunc calls. * Fix style issue
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 18, 2020
* [RUNTIME] Improve PackedFunc robustness - Add static assert to warn about unsupported type deduction. - Always inline template expansions for PackedFunc calls. * Fix style issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.