Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Relay][OP] Add fast_erf implementation #5241

Merged
merged 5 commits into from
Apr 7, 2020
Merged

[Relay][OP] Add fast_erf implementation #5241

merged 5 commits into from
Apr 7, 2020

Conversation

icemelon
Copy link
Member

@icemelon icemelon commented Apr 5, 2020

Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.

@anijain2305

anijain2305
anijain2305 approved these changes Apr 5, 2020
View reviewed changes
Copy link
Contributor

@anijain2305 anijain2305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

topi/include/topi/elemwise.h Outdated Show resolved Hide resolved
@anijain2305
Copy link
Contributor

Do you know why windows build is failing?

@icemelon
Copy link
Member Author

icemelon commented Apr 6, 2020 •
edited
Loading

Not really. The log shows the error

2020-04-05T22:36:45.4562113Z D:\a\incubator-tvm\incubator-tvm\topi\src\topi.cc : fatal error C1128: number of sections exceeded object file format limit: compile with /bigobj [D:\a\incubator-tvm\incubator-tvm\build.common\tvm_topi.vcxproj]

But in TVM cmake, we already set the /bigobj option.

@tqchen Do you have a better idea?

@tqchen
Copy link
Member

tqchen commented Apr 6, 2020

Let us try to break topi.cc into multiple files grouped by their .h

@icemelon
Copy link
Member Author

icemelon commented Apr 7, 2020

@anijain2305 ci is now green. Could you take a look again?

@anijain2305 anijain2305 merged commit f5b02fd into apache:master Apr 7, 2020
@anijain2305
Copy link
Contributor

Thanks @icemelon9 @tqchen This is merged

@icemelon icemelon deleted the fast-erf branch April 7, 2020 19:42
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Apr 16, 2020
@icemelon
[Relay][OP] Add fast_erf implementation (apache#5241)
3b1d0b6 
* add fast erf

* doc

* lint

* fix

* fix indent
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Apr 17, 2020
@icemelon @zhiics
[Relay][OP] Add fast_erf implementation (apache#5241)
29e2206 
* add fast erf

* doc

* lint

* fix

* fix indent
dpankratz pushed a commit to dpankratz/incubator-tvm that referenced this pull request Apr 24, 2020
@icemelon @dpankratz
[Relay][OP] Add fast_erf implementation (apache#5241)
af1d433 
* add fast erf

* doc

* lint

* fix

* fix indent
@ZihengJiang ZihengJiang mentioned this pull request Sep 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anijain2305 anijain2305 anijain2305 approved these changes

@Huyuwei Huyuwei Awaiting requested review from Huyuwei

@Laurawly Laurawly Awaiting requested review from Laurawly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@icemelon @anijain2305 @tqchen