[REFACTOR][IR] alpha_equal to structural_equal #5161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiics
commented
Mar 28, 2020
zhiics
commented
Mar 28, 2020
tqchen
changed the title
zhiics
force-pushed
the
structrual_equal
branch
2 times, most recently
from
7084d5c to
0795a86
Compare
|
@zhiics please rebase and check the testcases |
|
@tqchen sure. Seems a few tests are broken. I will look into after base. |
zhiics
force-pushed
the
structrual_equal
branch
2 times, most recently
from
5762186 to
de1ced1
Compare
zhiics
force-pushed
the
structrual_equal
branch
from
de1ced1 to
4308d59
Compare
tqchen
approved these changes
Mar 29, 2020
|
@zhiics can you comment a bit about what test-cases hit the incomplete type handling? That part might need some extra thoughts, I can merge this PR for now and we follow up on the particular item. cc @jroesch @MarisaKirisame |
|
I see, seems it makes sense now then. Thanks @zhiics ! |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Apr 16, 2020
zhiics
added a commit
to neo-ai/tvm
that referenced
this pull request
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5159
This PR finishes the first three items of #5159:
Replace
alpha_equal/type_alaph_equalandassert_alpha_equalfrom withstructural_equalReplace all
AlphaEqual(lhs, rhs)in C++ withStructuralEqual()(lhs, rhs)Remove analysis/alpha_equal.cc
A few bugs are also fixed in this PR.
A followup PR needs to remove the
AttrEqualandAlphaEqualHandlerfrom C++.