[Refactor] Relay Node::make to constructor #5128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiics
force-pushed
the
node_constructor
branch
from
6e5f86a to
93aa1bf
Compare
zhiics
commented
Mar 23, 2020
zhiics
commented
Mar 23, 2020
zhiics
force-pushed
the
node_constructor
branch
from
93aa1bf to
fa63e95
Compare
zhiics
force-pushed
the
node_constructor
branch
2 times, most recently
from
7eb01b8 to
723d6b3
Compare
zhiics
force-pushed
the
node_constructor
branch
from
723d6b3 to
b0a1e42
Compare
tqchen
requested changes
Mar 23, 2020
tqchen
approved these changes
Mar 23, 2020
|
@zhiics would you be able to do a quick patch to fix the remaining issue on the master? |
|
I can spend some time on it late today? could you please give a pointer to the remaining issue? |
|
Seems was a false alarm, neve rmind |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Apr 16, 2020
* relay Node::make to constructor * patternwildcard * Address comments
zhiics
added a commit
to neo-ai/tvm
that referenced
this pull request
Apr 17, 2020
* relay Node::make to constructor * patternwildcard * Address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5069