[RELAY] Codegen_c.h should include relay.function #5093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I015b2c66a50b64d0eb2e9efe336f6c18ea1fdc67
zhiics
approved these changes
Mar 18, 2020
|
Thanks @lhutton1 |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Apr 16, 2020
Change-Id: I015b2c66a50b64d0eb2e9efe336f6c18ea1fdc67
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Apr 17, 2020
Change-Id: I015b2c66a50b64d0eb2e9efe336f6c18ea1fdc67
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the build from failing when a 3rd party codegen includes codegen_c.h in its header file rather than in a source file. The reason this isn't an issue for dnnl, for example, is because the codegen class is declared in a source file. However, a 3rd party may have the codegen class declared in a header.