-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor][Relay] Refactor Relay Python to use new FFI #5077
Conversation
1681218
to
49e1a91
Compare
Some comments about docs and structure exposure.
|
In the case of the file groupings for relay/expr.py etc. There are two ways to think about it. We can either make them consistent with src/, which means we want relay/ir/expr.py, or first to be consistent with the include, in which case it is relay/expr.py. Given that tir already tries to be consistent with include first(as it is user facing), let us try to also do that in relay |
6b0031d
to
bc65305
Compare
@tqchen I updated the change. Moving the files back to the relay folder actually also resolves the user facing python API concern. |
Thanks @zhiics please also take note about the above comments for docs in general(see the new usage of automodule that removes the need of manual autofunction), but we can do that as a followup if CI is green |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some further comments
387c1db
to
a5cf36b
Compare
@tqchen PTAL, thanks. |
Thanks @zhiics |
* refactor relay python * revert relay/ir/*.py to relay * Address comments * remove direct access to analysis and transform namespace
* refactor relay python * revert relay/ir/*.py to relay * Address comments * remove direct access to analysis and transform namespace
#5068
This PRs refactors Relay to
Three followup PRs are needed to:
cc @tqchen @jroesch @icemelon9 @slyubomirsky @MarisaKirisame @wweic @yzhliu