Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Torch] Add initial 3D op support and test on Resnet 3D #5075

Merged
merged 11 commits into from
Mar 19, 2020
Merged

[Torch] Add initial 3D op support and test on Resnet 3D #5075

merged 11 commits into from
Mar 19, 2020

Conversation

masahi
Copy link
Member

@masahi masahi commented Mar 15, 2020 •
edited
Loading

  • Add support for conv3d and adaptive pool 3D in the torch frontend.
  • This enables loading Resnet 3D from torchvision. Added to the test.

please review @kevinthesun @anijain2305 @icemelon9 @jwfromm @alexwong @optima2005

jwfromm
jwfromm reviewed Mar 16, 2020
View reviewed changes
tests/python/frontend/pytorch/test_forward.py Outdated Show resolved Hide resolved
tests/python/frontend/pytorch/test_forward.py Outdated Show resolved Hide resolved
python/tvm/relay/frontend/pytorch.py Show resolved Hide resolved
jwfromm
jwfromm approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@jwfromm jwfromm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes / clarification. LGTM.

@masahi
Copy link
Member Author

masahi commented Mar 17, 2020

Ready to merge @kevinthesun @anijain2305 @icemelon9 @yzhliu @tqchen

anijain2305
anijain2305 reviewed Mar 19, 2020
View reviewed changes
Copy link
Contributor

@anijain2305 anijain2305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comments.

python/tvm/relay/frontend/pytorch.py Outdated Show resolved Hide resolved
python/tvm/relay/frontend/pytorch.py Outdated Show resolved Hide resolved
@masahi
Copy link
Member Author

masahi commented Mar 19, 2020

@anijain2305 ready to go

@anijain2305 anijain2305 merged commit 8607947 into apache:master Mar 19, 2020
@anijain2305
Copy link
Contributor

Thanks @masahi @jwfromm This is merged

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Apr 16, 2020
@masahi
[Torch] Add initial 3D op support and test on Resnet 3D (apache#5075)
2aadcba 
* fix minor lint issue

* add conv3d and adaptive avg pool3d conversion with test

* fix max pool handling

* add batch norm 3d test

* add resnet 3d test

* add more conv3d test

* clean up batch norm test

* add note on disabling inception v3 test

* add more tests

* add more tests

* fix names
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Apr 17, 2020
@masahi @zhiics
[Torch] Add initial 3D op support and test on Resnet 3D (apache#5075)
887cc22 
* fix minor lint issue

* add conv3d and adaptive avg pool3d conversion with test

* fix max pool handling

* add batch norm 3d test

* add resnet 3d test

* add more conv3d test

* clean up batch norm test

* add note on disabling inception v3 test

* add more tests

* add more tests

* fix names
@ZihengJiang ZihengJiang mentioned this pull request Sep 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anijain2305 anijain2305 anijain2305 approved these changes

@jwfromm jwfromm jwfromm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@masahi @anijain2305 @jwfromm