-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Graph tuner]Add opt out operator for has_multiple_inputs for graph tuner #5000
Conversation
@zhen-jia Overall lgtm. Can you take a look at the ci failure? |
|
You can create a dummy commit and re-trigger ci. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @zhen-jia |
…uner (apache#5000) * consider layout_transform in has_multiple_inputs * refactor code * remove debug info * remove subclass assignment * refactoring a little bit * remove default value * remove trailing whitespace * modify test for has_multiple_inputs Co-authored-by: Ubuntu <ubuntu@ip-172-31-40-194.us-west-2.compute.internal>
…uner (apache#5000) * consider layout_transform in has_multiple_inputs * refactor code * remove debug info * remove subclass assignment * refactoring a little bit * remove default value * remove trailing whitespace * modify test for has_multiple_inputs Co-authored-by: Ubuntu <ubuntu@ip-172-31-40-194.us-west-2.compute.internal>
If layout_transform is in the graph, graph tuner’s has_multiple_inputs will give wrong answer. This PR is to solve this problem.
@kevinthesun please help to review this