Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Graph tuner]Add opt out operator for has_multiple_inputs for graph tuner #5000

Merged
merged 9 commits into from
Mar 13, 2020

Conversation

zhen-jia
Copy link
Contributor

@zhen-jia zhen-jia commented Mar 6, 2020

If layout_transform is in the graph, graph tuner’s has_multiple_inputs will give wrong answer. This PR is to solve this problem.
@kevinthesun please help to review this

Ubuntu added 3 commits March 4, 2020 23:43

Partially verified

This commit is signed with the committer’s verified signature. The key has expired.
danielabrozzoni’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
@zhen-jia zhen-jia closed this Mar 6, 2020
@zhen-jia zhen-jia reopened this Mar 6, 2020
@kevinthesun kevinthesun changed the title And opt out operator for has_multiple_inputs for graph tuner [Graph tuner]Add opt out operator for has_multiple_inputs for graph tuner Mar 6, 2020
@kevinthesun
Copy link
Contributor

@zhen-jia Overall lgtm. Can you take a look at the ci failure?

@zhen-jia
Copy link
Contributor Author

@zhen-jia Overall lgtm. Can you take a look at the ci failure?
I am working on it and fixed the failures on my part. The current failure reported by rust test. It does not seem like caused by my changes. Any ideas? @kevinthesun

@kevinthesun
Copy link
Contributor

You can create a dummy commit and re-trigger ci.

Copy link
Contributor

@kevinthesun kevinthesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinthesun kevinthesun merged commit 2e913f0 into apache:master Mar 13, 2020
@kevinthesun
Copy link
Contributor

Thanks @zhen-jia

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Apr 16, 2020
…uner (apache#5000)

* consider layout_transform in has_multiple_inputs

* refactor code

* remove debug info

* remove subclass assignment

* refactoring a little bit

* remove default value

* remove trailing whitespace

* modify test for has_multiple_inputs

Co-authored-by: Ubuntu <ubuntu@ip-172-31-40-194.us-west-2.compute.internal>
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Apr 17, 2020
…uner (apache#5000)

* consider layout_transform in has_multiple_inputs

* refactor code

* remove debug info

* remove subclass assignment

* refactoring a little bit

* remove default value

* remove trailing whitespace

* modify test for has_multiple_inputs

Co-authored-by: Ubuntu <ubuntu@ip-172-31-40-194.us-west-2.compute.internal>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants