[Frontend][Torch] Check graph inputs match expected #4992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jjohnson-arm
commented
Mar 5, 2020
jjohnson-arm
commented
- error/warn when missing/unused graph inputs
* error/warn when missing/unused graph inputs
masahi
reviewed
Mar 5, 2020
python/tvm/relay/frontend/pytorch.py
Outdated
| def _check_input_names(graph, input_shapes): | ||
| """ Check the graph inputs match the inputs """ | ||
| # remove self at the 0th arg | ||
| ir_inputs = _get_input_names(graph)[1:] |
There was a problem hiding this comment.
Passing script_module and using _get_graph_input_names would be simpler?
There was a problem hiding this comment.
Fair enough - though I was just trying to avoid the extra graph.copy().
|
Let's wait until the github bug is fixed |
masahi
approved these changes
Mar 7, 2020
|
thanks @jjohnson-arm |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Apr 16, 2020
* [Frontend][Torch] Check graph inputs match expected * error/warn when missing/unused graph inputs * Change to use get_graph_input_names
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Apr 17, 2020
* [Frontend][Torch] Check graph inputs match expected * error/warn when missing/unused graph inputs * Change to use get_graph_input_names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.