Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FRONTEND][TENSORFLOW] support multiply outputs #4980

Merged
merged 2 commits into from
Mar 8, 2020
Merged

[FRONTEND][TENSORFLOW] support multiply outputs #4980

merged 2 commits into from
Mar 8, 2020

Conversation

vv1133
Copy link
Contributor

@vv1133 vv1133 commented Mar 3, 2020

Support TensorFlow multiply outputs.

@vv1133
Copy link
Contributor Author

vv1133 commented Mar 4, 2020

@srkreddy1238 @Huyuwei @hlu1
Could you please review?

srkreddy1238
srkreddy1238 approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@srkreddy1238 srkreddy1238 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

zhiics
zhiics reviewed Mar 4, 2020
View reviewed changes
Copy link
Member

@zhiics zhiics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a unit test?

@zhiics zhiics added the status: need test case need test cases to cover the change label Mar 4, 2020
@vv1133
Copy link
Contributor Author

vv1133 commented Mar 5, 2020

Can you add a unit test?

@zhiics There was multi_output test case in test_forward.py before，but it didn't test tf_testing.AddShapesToGraphDef function. I have updated it.

@vv1133 vv1133 requested a review from zhiics March 7, 2020 15:19
@zhiics
Copy link
Member

zhiics commented Mar 7, 2020

Please retrigger the ci

@vv1133
[TENSORFLOW][TEST] add tf_testing.AddShapesToGraphDef test
24e2b52 
* update frontend test

* retrigger CI
@vv1133 vv1133 force-pushed the frontend_tensorflow branch from a992c36 to 24e2b52 Compare March 8, 2020 03:27
@vv1133 vv1133 requested a review from zhiics March 8, 2020 06:05
@zhiics zhiics merged commit cf0a7e2 into apache:master Mar 8, 2020
@zhiics
Copy link
Member

zhiics commented Mar 8, 2020

Thanks @vv1133 @srkreddy1238

@zhiics zhiics added status: accepted and removed status: need test case need test cases to cover the change labels Mar 8, 2020
@vv1133 vv1133 deleted the frontend_tensorflow branch March 8, 2020 06:50
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Apr 16, 2020
@vv1133
[FRONTEND][TENSORFLOW] support multiply outputs (apache#4980)
b6c3820 
* [FRONTEND][TENSORFLOW] support multiply outputs

* [TENSORFLOW][TEST] add tf_testing.AddShapesToGraphDef test

* update frontend test

* retrigger CI
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Apr 17, 2020
@vv1133 @zhiics
[FRONTEND][TENSORFLOW] support multiply outputs (apache#4980)
48e262d 
* [FRONTEND][TENSORFLOW] support multiply outputs

* [TENSORFLOW][TEST] add tf_testing.AddShapesToGraphDef test

* update frontend test

* retrigger CI
@ZihengJiang ZihengJiang mentioned this pull request Sep 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srkreddy1238 srkreddy1238 srkreddy1238 approved these changes

@zhiics zhiics Awaiting requested review from zhiics

Assignees
No one assigned
Labels
status: accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vv1133 @zhiics @srkreddy1238