[Runtime] Fix TVM_DLL_EXPORT_TYPED_FUNC to work on Windows #4955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soiferj
changed the title
tqchen
approved these changes
Feb 27, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Apr 16, 2020
* [Runtime] Fixed TVM_DLL_EXPORT_TYPED_FUNC to work on Windows * fix style Co-authored-by: Jon Soifer <[email protected]>
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Apr 17, 2020
* [Runtime] Fixed TVM_DLL_EXPORT_TYPED_FUNC to work on Windows * fix style Co-authored-by: Jon Soifer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, it is not valid to define a function in the same statement as declaring it
dllexport. This change splitsTVM_DLL_EXPORT_PACKED_FUNCinto declaration and definition. Only declaration usesTVM_DLL.I have also verified that this change works on Linux.
@zhiics @comaniac would you be able to take a quick look?