[Frontend] [Tensorflow] ReadVariableOp operator support #4952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinthesun
reviewed
Feb 27, 2020
| # Add list of other operators as well which get removed | ||
| # and are not needed for inference. | ||
| # Other approach is instead of raising error, we can freeze the graph. | ||
| if 'ReadVariableOp' in missing_operators: |
There was a problem hiding this comment.
Is there any other op falling into this case? If so, I suggest we create a list containing all these ops.
There was a problem hiding this comment.
Yes, there are.
I will compile the list and add it in.
There was a problem hiding this comment.
Added other operators as well
|
Thanks @maheshambule |
|
Thanks, @kevinthesun for review and comments. |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Apr 16, 2020
* tf frontend read variable op * pylint fix * tf frontend freezed graph pruned ops
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Apr 17, 2020
* tf frontend read variable op * pylint fix * tf frontend freezed graph pruned ops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ReadVariableOp gets eliminated when you freeze the TensorFlow graph. It is also not needed for the inference.
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/framework/graph_util_impl.py#L464
If we find a ReadVariableOp in a TF graph, we error out and ask the user to provide a frozen graph.
TODO -
We may want to add support where we freeze the graph on the user's behalf when it is possible to freeze it otherwise we will throw an error.
@yongwww, @zhiics, @kevinthesun, @FrozenGene
Could you please review the PR?