Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Fix Sphinx Warning: the target found for cross-reference #4925

Merged
merged 2 commits into from
Feb 26, 2020

Conversation

cchung100m
Copy link
Contributor

Hi @tqchen @comaniac

Following issue #4908 and our discussion, this PR is going to fix the following two errors

WARNING: 'any' reference target not found: 
WARNING: Unknown target name: 

I would appreciate that if you could help to review/manage it, thanks.

@comaniac
Copy link
Contributor

The log shows 25 warnings including 4 undefined labels. Could you take a look and fix them? Other major warnings are related to lex python. You can also try to fix it, or I’ll take a look next week.

Sent with GitHawk

@tqchen tqchen added the status: need update need update based on feedbacks label Feb 25, 2020
@cchung100m
Copy link
Contributor Author

Hi @comaniac

Thanks for the review.

I solve the undefined label warnings and the output file as shown below link:

https://gist.github.com/cchung100m/f8bdef470b1a41c2408895610ee3b03e

Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I verified this PR locally and now we only have 3 warnings left:

WARNING: error while formatting arguments for tvm.relay.op.OpPattern: <class 'tvm.relay.op.op.OpPattern'> is a builtin class
WARNING: error while formatting arguments for tvm.intrin: module 'tvm.intrin' has no attribute '__mro__'
WARNING: error while formatting arguments for tvm.relay.vision.nms: module 'tvm.relay.op.vision.nms' has no attribute '__mro__'

@tqchen PTAL.

@cchung100m
Copy link
Contributor Author

@tqchen @comaniac

Thanks for the review and feedback. :)

@tqchen tqchen merged commit b598c54 into apache:master Feb 26, 2020
@tqchen tqchen added status: accepted and removed status: need update need update based on feedbacks labels Feb 26, 2020
@tqchen
Copy link
Member

tqchen commented Feb 26, 2020

Thansk @comaniac @cchung100m

alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 26, 2020
…he#4925)

* [DOCS] Fix Sphinx Warnings: the target found for cross-reference warnings

* Fix the warning: undefined label
@cchung100m cchung100m deleted the fix_sphinx_warning_target branch February 27, 2020 14:32
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 28, 2020
…he#4925)

* [DOCS] Fix Sphinx Warnings: the target found for cross-reference warnings

* Fix the warning: undefined label
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Mar 2, 2020
…he#4925)

* [DOCS] Fix Sphinx Warnings: the target found for cross-reference warnings

* Fix the warning: undefined label
tqchen pushed a commit to tqchen/tvm that referenced this pull request Mar 29, 2020
…he#4925)

* [DOCS] Fix Sphinx Warnings: the target found for cross-reference warnings

* Fix the warning: undefined label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants